Per the JDBC Spec calling commit() on a connection in auto-commit should raise 
a SQLException so what we’re doing is out of spec.

https://docs.oracle.com/javase/7/docs/api/java/sql/Connection.html#commit()

We should probably check c.getProperty(AUTO_COMMIT).asBoolean() and only call 
commit if we weren’t in auto commit mode. I’ll file a jira

Thanks
Shawn

From: Shawn Weeks <swe...@weeksconsulting.us>
Reply-To: "users@nifi.apache.org" <users@nifi.apache.org>
Date: Wednesday, June 3, 2020 at 2:27 PM
To: "users@nifi.apache.org" <users@nifi.apache.org>
Subject: PutSQL and AutoCommit Mode Still Commits

It appears that PutSQL calls a commit even when set to autoCommit true mode. 
This breaks things if a driver raises an error on commit in autoCommit mode. 
For example redshift does this.

Thanks
Shawn


Reply via email to