Hi,
On Wed, 24 Jun 2009 16:35:33 +0900, Jiro SEKIBA <[email protected]> wrote:
> Hi,
>
> This is a proposed patch to display mount options in procfs.
> Mount options will show up in the /proc/mounts as other fs does.
>
> # mount.nilfs2 -o ro,barrier=off,cp=3,order=strict /dev/sda6 /mnt
> # cat /proc/mounts
> ...
> /dev/sda6 /mnt nilfs2
> ro,relatime,barrier=off,cp=3,errors=continue,order=strict 0 0
> ...
>
> thanks
>
> regards,
> --
> Jiro SEKIBA <[email protected]>
Thank you for the patch!
Could you append "Signed-off-by:" field to the changelog?
It is automatically inserted by using -s option when committing
change.
$ git commit -s
Also, there are a few coding style violations.
Please look at Documentation/CodingStyle file and apply
scripts/checkpatch.pl to verify violations.
Thanks,
Ryusuke Konishi
> ---
> fs/nilfs2/super.c | 31 ++++++++++++++++++++++++++++++-
> 1 files changed, 30 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
> index ab785f8..123d14f 100644
> --- a/fs/nilfs2/super.c
> +++ b/fs/nilfs2/super.c
> @@ -50,6 +50,8 @@
> #include <linux/writeback.h>
> #include <linux/kobject.h>
> #include <linux/exportfs.h>
> +#include <linux/seq_file.h>
> +#include <linux/mount.h>
> #include "nilfs.h"
> #include "mdt.h"
> #include "alloc.h"
> @@ -537,6 +539,33 @@ static int nilfs_statfs(struct dentry *dentry, struct
> kstatfs *buf)
> return 0;
> }
>
> +static int nilfs_show_options(struct seq_file *seq, struct vfsmount *vfs)
> +{
> + struct super_block *sb = vfs->mnt_sb;
> + struct nilfs_sb_info *sbi = NILFS_SB(sb);
> +
> + if(!nilfs_test_opt(sbi,BARRIER)) {
> + seq_printf(seq,",barrier=off");
> + }
> + if(nilfs_test_opt(sbi,SNAPSHOT)) {
> + seq_printf(seq,",cp=%llu",sbi->s_snapshot_cno);
> + }
> + if(nilfs_test_opt(sbi,ERRORS_CONT)) {
> + seq_printf(seq,",errors=continue");
> + }
> + if(nilfs_test_opt(sbi,ERRORS_RO)) {
> + seq_printf(seq,",errors=remount-ro");
> + }
> + if(nilfs_test_opt(sbi,ERRORS_PANIC)) {
> + seq_printf(seq,",errors=panic");
> + }
> + if(nilfs_test_opt(sbi,STRICT_ORDER)) {
> + seq_printf(seq,",order=strict");
> + }
> +
> + return 0;
> +}
> +
> static struct super_operations nilfs_sops = {
> .alloc_inode = nilfs_alloc_inode,
> .destroy_inode = nilfs_destroy_inode,
> @@ -554,7 +583,7 @@ static struct super_operations nilfs_sops = {
> .remount_fs = nilfs_remount,
> .clear_inode = nilfs_clear_inode,
> /* .umount_begin */
> - /* .show_options */
> + .show_options = nilfs_show_options
> };
>
> static struct inode *
> --
> 1.5.6.5
>
_______________________________________________
users mailing list
[email protected]
https://www.nilfs.org/mailman/listinfo/users
