Hi, At Sun, 8 Nov 2009 19:26:16 +0900, Ryusuke Konishi wrote: > > Hi, > 2009/11/8 Jiro SEKIBA <[email protected]>: > > Hi, > > > > This is a trivial patch to expose struct nilfs_fs_btree_node. > > The struct sould be exposed outside of kernel, for it is disk format. > > > > Signed-off-by: Jiro SEKIBA <[email protected]> > > Thank you for this patch. > > > --- > > fs/nilfs2/btree.h | 22 ---------------------- > > include/linux/nilfs2_fs.h | 23 +++++++++++++++++++++++ > > 2 files changed, 23 insertions(+), 22 deletions(-) > > > > diff --git a/fs/nilfs2/btree.h b/fs/nilfs2/btree.h > > index 0e72bbb..4b82d84 100644 > > --- a/fs/nilfs2/btree.h > > +++ b/fs/nilfs2/btree.h > > @@ -34,28 +34,6 @@ struct nilfs_btree; > > struct nilfs_btree_path; > > > > /** > > - * struct nilfs_btree_node - B-tree node > > - * @bn_flags: flags > > - * @bn_level: level > > - * @bn_nchildren: number of children > > - * @bn_pad: padding > > - */ > > -struct nilfs_btree_node { > > - __u8 bn_flags; > > - __u8 bn_level; > > - __le16 bn_nchildren; > > - __le32 bn_pad; > > -}; > > - > > -/* flags */ > > -#define NILFS_BTREE_NODE_ROOT 0x01 > > - > > -/* level */ > > -#define NILFS_BTREE_LEVEL_DATA 0 > > -#define NILFS_BTREE_LEVEL_NODE_MIN (NILFS_BTREE_LEVEL_DATA + 1) > > -#define NILFS_BTREE_LEVEL_MAX 14 > > - > > -/** > > * struct nilfs_btree - B-tree structure > > * @bt_bmap: bmap base structure > > */ > > diff --git a/include/linux/nilfs2_fs.h b/include/linux/nilfs2_fs.h > > index 79fec6a..5e326de 100644 > > --- a/include/linux/nilfs2_fs.h > > +++ b/include/linux/nilfs2_fs.h > > @@ -773,6 +773,29 @@ struct nilfs_bdesc { > > __u32 bd_pad; > > }; > > > > +/** > > + * struct nilfs_btree_node - B-tree node > > + * @bn_flags: flags > > + * @bn_level: level > > + * @bn_nchildren: number of children > > + * @bn_pad: padding > > + */ > > +struct nilfs_btree_node { > > + __u8 bn_flags; > > + __u8 bn_level; > > + __le16 bn_nchildren; > > + __le32 bn_pad; > > +}; > > + > > +/* flags */ > > +#define NILFS_BTREE_NODE_ROOT 0x01 > > + > > +/* level */ > > +#define NILFS_BTREE_LEVEL_DATA 0 > > +#define NILFS_BTREE_LEVEL_NODE_MIN (NILFS_BTREE_LEVEL_DATA + 1) > > +#define NILFS_BTREE_LEVEL_MAX 14 > > + > > + > > #define NILFS_IOCTL_IDENT 'n' > > > > #define NILFS_IOCTL_CHANGE_CPMODE \ > > -- > > 1.5.6.5 > > Seems that the nilfs_btree_node struct was moved into the middle of > ioctl related declarations. > > I think it should come before the definition of nilfs_palloc_group_desc > struct or so.
Grr, I'll revise and resend the patch. Thank you for the review. > Thanks, > Ryusuke Konishi > _______________________________________________ > users mailing list > [email protected] > https://www.nilfs.org/mailman/listinfo/users > > > -- Jiro SEKIBA <[email protected]> _______________________________________________ users mailing list [email protected] https://www.nilfs.org/mailman/listinfo/users
