2019-06-02 15:39:12 UTC - Shivji Kumar Jha: Unlike PulsarClient.builder(), It 
seems ClientConfigurationData.java does not understand that pulsar+ssl:// => 
isUseTls == true.
I even tried this in PulsarClientImpl to fix this.
```    public PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup 
eventLoopGroup, ConnectionPool cnxPool) throws PulsarClientException {
…
        if (!conf.isUseTls()) {
            conf.setUseTls(conf.getServiceUrl().startsWith("pulsar+ssl") || 
conf.getServiceUrl().startsWith("https"));
        }
…
}
```
Doesn’t work. Though tls works if you explicitly do a 
clientConfig.setUseTls(true);
Am I missing something?
----
2019-06-02 19:15:37 UTC - Shivji Kumar Jha: I have tried this with 2.3.1 and 
2.3.2 java client versions.
----
2019-06-02 19:19:51 UTC - Matteo Merli: I haven’t checked now but I think it’s 
being applied in the builder itself, since the ClientConfigurationData was more 
of an internal construct. Though it would make sense to make the behavior 
consistent across the two. 
----
2019-06-02 20:51:47 UTC - Shivji Kumar Jha: Yes @Matteo Merli i am trying to do 
precisely that - write a patch for making both consistent. And I thought the 
above mentioned code change should fix it. But it seems there is some code 
where tls is being overwritten :disappointed:
----

Reply via email to