On Mon, 2014-02-03 at 21:08 +0000, Gordon Sim wrote:
> ...
> [...]
> >> However we could probably look at ways to (optionally?) make this more
> >> lenient. It certainly is also something that should be highlighted
> >> more prominently in documentation somehow.
> > It would be *really really good* to be able to make this more lenient
> > (would quoted field names be a possibility e.g.
> > 'data-service'='amqp-delivery')?

It is certainly possible to make the selector parser more lenient
generally. However I'd be against parameterising the parser itself (for
complexity and testability reasons) and we'd have to think carefully
before allowing something like this that isn't valid JMS selector
syntax. This particular suggestion can't work as single quote is the JMS
selector string quote character, perhaps an Access SQL like square
brackets syntax (eq [amqp-delivery] or
[this is a silly name for a property]) would work?

In the structure of the C++ selector parser it is simple to change the
reserved identifiers so we could support pukka JMS identifiers as well
as the amqp 1.0 registered extension identifiers 

> 
> I've not looked at the parsing code, but I would think something like 
> that should be possible and I agree that it would be useful since AMQP 
> itself places no restrictions on property names.
> 
> [...]
> >> I believe the selector filters are supported by a number of brokers
> >> outside Qpid (ActiveMQ, HornetQ, SwiftMQ).
> > That's useful to know, have you tried many interoperability scenarios?
> 
> I've successfully tried selectors against ActiveMQ. The only quirk is 
> that it doesn't actually recognise the filters descriptor, but just 
> recognises the filter name as used by the current qpid JMS over 1.0 
> client. SO the selector shorthand doesn't work, but a fully specified 
> filter will.

For interop purposes we could certainly change the filter name we use -
file a JIRA?

Andrew



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
For additional commands, e-mail: users-h...@qpid.apache.org

Reply via email to