I've tested this against dispatch trunk and 0.4 branch with no problems, so this looks good to me apart from the SSL issue mentioned below.
On Mon, 2015-03-09 at 14:39 +0000, Gordon Sim wrote: > On 03/09/2015 02:14 PM, Ken Giusti wrote: > > Additionally, the following python unit tests fail unless the openssl > > libraries are installed: > > > > proton_tests.engine.ServerTest.testIdleTimeout > > proton_tests.engine.ServerTest.testKeepalive > > proton_tests.messenger.IdleTimeoutTest.testIdleTimeout > > proton_tests.utils.SyncRequestResponseTest.test_request_response > > > > All the other ssl tests raise the Skip exception, which I believe should be > > done for the above as well. > > > > All failures have a traceback similar to this: > > > > 1: Error during test: Traceback (most recent call last): > > 1: File > > "/home/kgiusti/Downloads/qpid-proton-0.9-rc-1/tests/python/proton-test", > > line 355, in run > > 1: phase() > > 1: File > > "/home/kgiusti/Downloads/qpid-proton-0.9-rc-1/tests/python/proton_tests/engine.py", > > line 1882, in testIdleTimeout > > 1: server = common.TestServer(idle_timeout=idle_timeout) > > 1: File > > "/home/kgiusti/Downloads/qpid-proton-0.9-rc-1/tests/python/proton_tests/common.py", > > line 127, in __init__ > > 1: self.reactor = Container(self) > > 1: File > > "/home/kgiusti/Downloads/qpid-proton-0.9-rc-1/proton-c/bindings/python/proton/reactor.py", > > line 588, in __init__ > > 1: self.ssl = SSLConfig() > > 1: File > > "/home/kgiusti/Downloads/qpid-proton-0.9-rc-1/proton-c/bindings/python/proton/reactor.py", > > line 566, in __init__ > > 1: self.client = SSLDomain(SSLDomain.MODE_CLIENT) > > 1: File > > "/home/kgiusti/Downloads/qpid-proton-0.9-rc-1/proton-c/bindings/python/proton/__init__.py", > > line 3371, in __init__ > > 1: raise SSLUnavailable() > > 1: SSLUnavailable > > > > I suspect the reactor shouldn't fail in these cases if SSL is not available. > > I have checked in a fix for that to master. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org