Your fix is working [??]

19: Test timeout computed to be: 1500
19: test_simple_pre_settled (system_tests_protocol_family.ProtocolFamilyTest) 
... skipped 'Skipping test..IPV6 not enabled'
19:
19: ----------------------------------------------------------------------
19: Ran 1 test in 0.001s
19:
19: OK (skipped=1)
1/1 Test #19: system_tests_protocol_family .....   Passed    0.11 sec

Regards,
Adel

________________________________
From: Ganesh Murthy <gmur...@redhat.com>
Sent: Wednesday, February 1, 2017 4:11:14 PM
To: users@qpid.apache.org
Subject: Re: [GitHub] qpid-dispatch pull request #140: DISPATCH-216 - Added 
code to skip system_te...

Hi Adel,
Like you mentioned, the earlier PR was checking incorrect error message because 
the error message on Solaris is different.

Based on your input, I have submitted a new pull request - 
https://github.com/apache/qpid-dispatch/pull/141

Please go ahead and give that a try (after backing out the previous code). 
Please try running only the system_tests_protocol_family after applying the new 
PR. If that goes well, I will fix the other tests as well.

Thanks.

----- Original Message -----

> From: "Adel Boutros" <adelbout...@live.com>
> To: users@qpid.apache.org
> Sent: Wednesday, February 1, 2017 9:17:55 AM
> Subject: Re: [GitHub] qpid-dispatch pull request #140: DISPATCH-216 - Added
> code to skip system_te...

> Hello Ganesh,

> I tested your pull request and it doesn't seem that the error message you
> check for in " is_ipv6_enabled" is correct.

> In my case, Exception e is ( print "---->%s: %s" %(type(e), str(e)) ): "
> <class 'socket.error'>: getsockaddrarg: bad family "

> I have attached the log of all the tests. This way you can see what is
> happening. I think there are multiple errors being shown.

> I am also attaching the patch which I had used to disable IPv6 brutally (Of
> course it is not a patch to be accepted but just to show you what we had to
> do to ignore the errors).

> Regards,

> Adel

> From: Ganesh Murthy <gmur...@redhat.com>
> Sent: Tuesday, January 31, 2017 8:24:12 PM
> To: users@qpid.apache.org
> Subject: Fwd: [GitHub] qpid-dispatch pull request #140: DISPATCH-216 - Added
> code to skip system_te...
> Hi Adel,
> Can you please apply this pull request in your environment and let me know if
> the system_tests_protocol_family.py tests are skipped.
> Thanks.

> ----- Forwarded Message -----
> From: "ganeshmurthy" <g...@git.apache.org>
> To: d...@qpid.apache.org
> Sent: Tuesday, January 31, 2017 2:19:38 PM
> Subject: [GitHub] qpid-dispatch pull request #140: DISPATCH-216 - Added code
> to skip system_te...

> GitHub user ganeshmurthy opened a pull request:

> https://github.com/apache/qpid-dispatch/pull/140

> DISPATCH-216 - Added code to skip system_tests_protocol_family.py if …

> …IPv6 is turned off

> You can merge this pull request into a Git repository by running:

> $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-216

> Alternatively you can review and apply these changes as the patch at:

> https://github.com/apache/qpid-dispatch/pull/140.patch

> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:

> This closes #140

> ----
> commit a0b16449e7fd257b2abee347ae211ab6a33bc53c
> Author: Ganesh Murthy <gmur...@redhat.com>
> Date: 2017-01-31T19:18:10Z

> DISPATCH-216 - Added code to skip system_tests_protocol_family.py if IPv6 is
> turned off

> ----

> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
> For additional commands, e-mail: dev-h...@qpid.apache.org

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
> For additional commands, e-mail: users-h...@qpid.apache.org

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
> For additional commands, e-mail: users-h...@qpid.apache.org

Reply via email to