+1 with the following caveat: I'm developing a new client failover test <https://github.com/apache/qpid-dispatch/pull/564> that should reproduce and verify the issue uncovered in DISPATCH-1406 <https://issues.apache.org/jira/browse/DISPATCH-1406> (which is fixed in 1.9.0-rc2). Running this test on the RC2 candidate uncovers a new memory leak. See DISPATCH-1426 <https://issues.apache.org/jira/browse/DISPATCH-1426> for details on the leak.
Note well that the test does verify that 1406 is fixed in RC2. The reason I don't feel it is necessary to -1 the RC2 is that I can trigger the DISPATCH-1426 issue in 1.8.0 also. The issue is NOT a regression. Actually, running the new test on 1.8.0 causes the router to crash due to DISPATCH-1380 <https://issues.apache.org/jira/browse/DISPATCH-1380> which is fixed in 1.9.0-RC2. I was only able to reproduce 1426 on 1.8.0 after I backported the 1380 fix. I feel that the fix for 1380 is of higher priority than 1426 and feel that we should not delay 1.9.0 while we look for a fix to a leak that likely will not be hit since the router will most likely crash due to 1380 first. I propose we ship 1.9.0 with 1426 noted. Agreed? On Mon, Sep 16, 2019 at 2:17 PM Ganesh Murthy <gmur...@apache.org> wrote: > Hello All, > > Please cast your vote on this thread to release RC2 as the > official Qpid Dispatch Router version 1.9.0. > > RC2 of Qpid Dispatch Router version 1.9.0 can be found here: > > https://dist.apache.org/repos/dist/dev/qpid/dispatch/1.9.0-rc2/ > > The following improvements, and bug fixes are introduced in 1.9.0: > > Improvements - > DISPATCH-480 - Default tests timeout is too short for some machines > DISPATCH-1266 - Improve router's handling of unsettled multicast > deliveries > DISPATCH-1338 - Improvements to edge router documentation > DISPATCH-1345 - Reduce the number of QDR_LINK_FLOW events by > coalescing credit grants > DISPATCH-1346 - Create documentation for priority delivery > DISPATCH-1347 - Update documentation for Dispatch Router console > DISPATCH-1350 - Update logging/monitoring documentation > DISPATCH-1353 - Document how to configure access policy control on > router-initiated connections > DISPATCH-1354 - Interrouter annotation processing uses slow methods > DISPATCH-1370 - Move the schema, connect, and entities tabs to the > right in the console > DISPATCH-1372 - alloc_pool intrusive linked list can be replaced > by a linked stack > DISPATCH-1374 - Add qdstat options --all-routers and all-entities > which display statistics of all routers and displays all entities > DISPATCH-1376 - Make it easier to change the product name in the > console > DISPATCH-1379 - Message receive performance improvements > DISPATCH-1381 - Create documentation for configuring fallback > destinations > DISPATCH-1382 - Document ability to force-close a connection from > the web console > DISPATCH-1385 - qd_message_list_t is dead code > DISPATCH-1388 - Authorization doc fails to describe vhost > abstraction clearly > DISPATCH-1396 - Doc how to start the router > > Bugs - > DISPATCH-1359 - Set ctest timeout to 300 seconds. > DISPATCH-1361 - system_tests_fallback_dest hanging in some cases > DISPATCH-1362 - Shutdown crash when trying to clean up fallback > addresses > DISPATCH-1365 - Table of links with delayed deliveries is showing > all endpoint links > DISPATCH-1378 - missing lock of connection's links_with_work list > DISPATCH-1380 - qdrouterd leaves dangling qd_link_t pointer > DISPATCH-1383 - system_tests_policy is timing out > DISPATCH-1387 - Coverity issues on master branch > DISPATCH-1391 - Proton link reference not cleared on router link > objects during session close > DISPATCH-1394 - qd_check_message() incorrectly validates partially > received messages > DISPATCH-1398 - "Expression with no effect" warning for console web > DISPATCH-1404 - message annotation parsing incorrectly uses > ->remainder for current buffer capacity > DISPATCH-1406 - Inter-router link stall on receive client failover > DISPATCH-1407 - Memory leak on link policy denial > DISPATCH-1408 - system_tests_distribution failing when running > under valgrind > DISPATCH-1410 - attach of auto-links not logged > DISPATCH-1413 - system_tests_two_routers.py failing intermittently on > Travis > DISPATCH-1417 - Crash when connection_wake ctx points to freed memory > > Thanks. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > > -- -K
