Please raise a JIRA with all this information and the reproducer - it is very hard to track fixes without this.
Also you could attach your patch, but it is easier in this case to use a github PR with a reference to the JIRA. The Apache automation will tie them together and this makes it again easier to track. Andrew On Tue, 2019-11-19 at 18:04 +0000, HADI Ali wrote: > Hello, > > After analysis we discovered that the regression is coming from > PROTON-2075< > https://github.com/apache/qpid-proton/commit/e152190459cd75792002d2aae72d351dc22abe27> > ;: [C++] Allow TLS to use system default trusted certificate. > In fact we noticed that the ssl_client_options and the > ssl_server_options are not default constructed the same way and that > the second one< > https://github.com/apache/qpid-proton/blob/e152190459cd75792002d2aae72d351dc22abe27/cpp/src/ssl_options.cpp#L99 > > is calling pni_init_ssl_domain< > https://github.com/apache/qpid-proton/blob/9dd013335de0694bc52848897b17190f297450c1/c/src/ssl/openssl.c#L475 > > which is taking some time. > > What we would like is to avoid initializing ssl when it’s disabled > from the connection_options. > Does it sound reasonable for you? Should we create a Jira issue and > propose a fix? > > Thanks, > Ali & Rabih > > From: Rabih M <[email protected]> > Sent: mercredi 13 novembre 2019 19:22 > To: [email protected] > Subject: [Qpid-proton-cpp] Performance regression found in 0.29.0 > > Hello, > > We are upgrading in our code the proton version from 0.27.0 to > 0.29.0. > While running our unit tests, we found a considerable performance > regression. > > We were able to reproduce the regression in a very simple use case. > Please find the code attached. > > This test takes 1 ms in the version 0.27.0 and 0.28.0 but it takes 73 > ms in 0.29.0 . > > Do you know what might be the cause? > We will try to investigate in parallel from our side, too. > > Thanks, > Rabih & Ali > ******************************* > This e-mail contains information for the intended recipient only. It > may contain proprietary material or confidential information. If you > are not the intended recipient you are not authorized to distribute, > copy or use this e-mail or any attachment to it. Murex cannot > guarantee that it is virus free and accepts no responsibility for any > loss or damage arising from its use. If you have received this e-mail > in error please notify immediately the sender and delete the original > email received, any attachments and all copies from your system. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
