In some ways I think versioning it 1.14.0 might make sense, as basically the change will mean that feature doesn't work between the new and old router (even though it could, it just wouldn't be detected). In some ways that would seem surprising for a 1.13.1 router to 'not work' (obviously it's just this optimisation/feature that wouldn't enable) with 1.13.0, or at least a bit more than it would for a 1.14.0 not to. Slight benefit of 1.13.0 basically disappearring, with likely few to none yet using it, and 1.14.x essentially quickly replacing it. On the other hand, I can see it is essentially a bug in the original impl, so it wouldn't be 'wrong' to version it that way, just maybe a little more surprising?
Robbie On Tue, 1 Sep 2020 at 16:29, Ken Giusti <[email protected]> wrote: > > Folks, > > 1.13.0 contains a new feature that allows the router to open additional > outgoing links on an inter-router connection to better support streaming of > large outgoing messages (see [0]). > > Unfortunately that fix made some bad assumptions on the format of the > version string that the router advertises when opening a connection. [0] > uses the peer router's version to decide whether or not it supports the > ability to accept additional links on the inter-router connection. > > This issue essentially disables the feature when the version string is > customized. > > I've introduced a fix [1] that removes the version string parsing and > replaces it with capabilities advertised via the @open performative. > > Would it be possible to release this fix as a patch release to 1.13.0? > > [0] https://issues.apache.org/jira/browse/DISPATCH-1545 > [1] https://issues.apache.org/jira/browse/DISPATCH-1765 > > thanks > > -- > -K --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
