Hello folks,

(https://issues.apache.org/jira/browse/DISPATCH-1814 Apply autofixes to
resolve some flake8 code formatting issues)

I have prior positive experience with autopep8,
https://pypi.org/project/autopep8/. It is a tool to automatically reformat
Python source code. It can either selectively reformat to fix only a
specific flake8 warning, or it can just do it all in one go.

What do you think about running this on the Qpid Proton and Qpid Dispatch
code? Is there a good time when to do it? Would it be better to fix each
warning individually, in its own commit (to simplify manual review), or do
it all in one commit (to simplify git history, and spend less time on it)?

I am personally in favour of a single commit in which to do all the
whitespace changes in one go. I've always found autopep8 to work reliably.

Regarding potential issues, whitespace changes would affect ongoing work in
progress (although the autoformatter can be run on the PRs as well), so it
seems to me that a good time to land this would be after a release.
-- 
Mit freundlichen Grüßen / Kind regards
Jiri Daněk

Reply via email to