On Wed, 2020-12-16 at 11:48 +0000, Pete Fawcett wrote: > Dear Qpid Users > > I was advised to re-send the message below to this mailing list > rather than > the "dev" one - I hope this won't be seen as spamming :-)
Just to note (in case you didn't see the PR itself yet) that I have reviewed the PR and there are some small changes that need making. I think that if the change is rebased "as is" it should pass the tests with no further ado. Andrew > > ---------- Forwarded message --------- > > I would be grateful for some advice regarding the following Pull > Request > > https://github.com/apache/qpid-proton/pull/278 > > This is my first Qpid Pull Request and so I am still unfamiliar with > the > process. > > It is an enhancement to the Proton C++ bindings to allow access to > the > "custom" properties of a connection. e.g. to set the > "qpid.client_process" > property. > > Firstly, what should I do about the failed builds? They seem to be > related > to errors/problems in the build system(s) rather than to changes I > have > made, but I might be missing something. > > Secondly, and connected, do I need to get this PR to pass all the > build > checks before it is eligible for review, or is there something else I > have > to do (apart from being more patient) ? > > Thanks for any help - especially from anyone who would like to review > the > PR. > > Pete --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
