Hi Piotr ,
1.Created a branch : https://github.com/alinakazi/royale-asjs/tree/mxRoyaleAQ 2.Added file ListEvent.as manually to the location using upload file at: https://github.com/alinakazi/royale-asjs/tree/mxRoyaleAQ/frameworks/projects/MXRoyale/src/main/royale/mx/events 3.Created a Pull Request at:https://github.com/apache/royale-asjs/compare/feature/MXRoyale...alinakazi:mxRoyaleAQ?expand=1 https://github.com/apache/royale-asjs/pull/138/files Thanks, Alina Kazi From: Piotr Zarzycki [mailto:piotrzarzyck...@gmail.com] Sent: Thursday, March 29, 2018 4:38 PM To: users@royale.apache.org Subject: Re: Work on Emulation I think adding through the console is also ok. If you affect your branch you will be able to fix that. You won't affect Main repository, because you don't have commit rights yet. You can do pull requests only. Do not hesitate try. Again: 1) You have your branch mxRoyaleAK 2) Switch to that branch - make commit and push those files Let me know once you do that part. Thanks, Piotr 2018-03-29 13:21 GMT+02:00 Alina Kazi <alina.k...@d-bz.com>: Currently, I am not using <https://github.com/alinakazi/royale-asjs> https://github.com/alinakazi/royale-asjs Do you want me to add my file Manually ? https://github.com/alinakazi/royale-asjs/tree/feature/MXRoyale/frameworks/projects/MXRoyale/src/main/royale/mx/events https://www.dropbox.com/s/mfu97rjb59e8o2q/upload.png?dl=0 Sorry, I am asking too many Questions. Just because I don’t want to do something wrong, that effect the whole branch. Thanks, Alina Kazi From: Piotr Zarzycki [mailto:piotrzarzyck...@gmail.com] Sent: Thursday, March 29, 2018 3:55 PM To: users@royale.apache.org Subject: Re: Work on Emulation Are you pushing to your forked royale-asjs ? -> https://github.com/alinakazi/royale-asjs, because I think you should do that in that way. Than doing a pull request to the main repository. 2018-03-29 12:44 GMT+02:00 Alina Kazi <alina.k...@d-bz.com>: Should I write git push --set-upstream origin mxRoyaleAK Instead of git push as instructed below: D:\new\royale-asjs>git push fatal: The current branch mxRoyaleAK has no upstream branch. To push the current branch and set the remote as upstream, use git push --set-upstream origin mxRoyaleAK Thanks, Alina From: Piotr Zarzycki [mailto:piotrzarzyck...@gmail.com] Sent: Thursday, March 29, 2018 3:23 PM To: users@royale.apache.org Subject: Re: Work on Emulation I don't see your commit. It looks like I have missed in your screenshot "git push" - In git you are committing and later pushing. Commit doesn't mean that it's in the repository. Thank you are doing pull request. 2018-03-29 12:13 GMT+02:00 Piotr Zarzycki <piotrzarzyck...@gmail.com>: It looks good. Try to make pull request against MXRoyale and see whether only those files are you seeing changed. 2018-03-29 12:10 GMT+02:00 Alina Kazi <alina.k...@d-bz.com>: Hi Piotr, Created a new branch mxRoyaleAK Switch to the branch ListEvent.as File Copied The result is : https://www.dropbox.com/s/g5bxzr472r2hidu/addtobranch.png?dl=0 Is it ok? Thanks, Alina From: Piotr Zarzycki [mailto:piotrzarzyck...@gmail.com] Sent: Thursday, March 29, 2018 1:08 PM To: users@royale.apache.org Subject: Re: Work on Emulation Alina, If you are create branch based on MXRoyale - you will have exactly the same hierarchy as it is in that branch. Once you add everything what you need, make pull request we will merge it into the MXRoyale. Actually when you will be working on your branch once you create pull request GitHub should automatically show those branches. You can thing about branch like copy of MXRoyale. 2018-03-29 9:45 GMT+02:00 Alina Kazi <alina.k...@d-bz.com>: Hi Piotr, Peter and Alex are using MXRoyale branch to work on emulation. You want me to create another branch and add my files to it. Then, open a pull request and I should select the drop down list: Base: MXRoyale <- Compare:MyBranch If these are the steps that I should follow, I want to ask few questions regarding the branch I will create 1. Is it necessary to create similar Hierarchy? e.g. If I want to add ListEvent.as file so I should add it to (royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\events) 2. To compile my file I should use actual MXRoyale Branch , But to add files I should use myBranch that contains only files that are added/changed by me? Thanks, Alina From: Piotr Zarzycki [mailto:piotrzarzyck...@gmail.com] Sent: Thursday, March 29, 2018 12:04 PM To: users@royale.apache.org Subject: Re: Work on Emulation Hi Alina, On your screenshot I see to many files changed. The best way of work with pull request are branches. 1. You pickup some control to work from raised issue - create new branch against MXRoyale - alert_mxroyale - just an example 2. Once all your changes you have in your branch - open pull request - you should see in the drop down list: MXRoyale - yourbranch In the changed files you will have only those which you have added/changed. 3. Whenever you will work on new stuff creat branches We will be able to review and comment your pull requests. Thoughts? Piotr On Thu, Mar 29, 2018, 08:00 Alina Kazi <alina.k...@d-bz.com> wrote: I understand that I need to follow below mentioned steps to work on a new emulation component: 1. I will copy files from flex-sdk branch to my local machine, 2. I will make changes in the files on my local machine based on the document available on “Setup & Migration -> <https://github.com/apache/royale-asjs/wiki/emulation-components> Emulation Components” link. 3. I will create a Pull Request to merge my changes on Github so that others can review it Please confirm that my understanding is correct and I haven’t missed any step. Thanks Alina From: Alina Kazi [mailto:alina.k...@d-bz.com] Sent: Thursday, March 29, 2018 9:07 AM To: users@royale.apache.org Subject: RE: Work on Emulation https://github.com/apache/royale-asjs/compare/develop...feature/MXRoyale While creating a Pull Request Should I need to copy both files 1. That is copied from flex sdk 2. Latest file with changes And please check all other things like branches ,Title, Description in below given link https://www.dropbox.com/s/a56yg3n8wx92b83/pullrequest.png?dl=0 If all are ok. I will create a Pull Request for ListEvent. Thanks, Alina Kazi From: Alex Harui [mailto:aha...@adobe.com] Sent: Wednesday, March 28, 2018 8:55 PM To: users@royale.apache.org Subject: Re: Work on Emulation Actually, I think Alina's version is sufficient/correct for now. Her app is not using IListItemRenderer in ListEvent. Alina, let's try using GitHub's tools instead of DropBox for code review. Take this code and create a Pull Request. Thanks, -Alex From: Peter Ent <p...@adobe.com> Reply-To: "users@royale.apache.org" <users@royale.apache.org> Date: Wednesday, March 28, 2018 at 7:16 AM To: "users@royale.apache.org" <users@royale.apache.org> Subject: Re: Work on Emulation Hi, You will have to bring over IListItemRenderer. IRoyaleEvent is available so the clone function should be OK to use. —peter From: Alina Kazi <alina.k...@d-bz.com> Reply-To: "users@royale.apache.org" <users@royale.apache.org> Date: Wednesday, March 28, 2018 at 7:48 AM To: "users@royale.apache.org" <users@royale.apache.org> Subject: RE: Work on Emulation Alex, Latest ListEvent file Link: https://www.dropbox.com/s/6k0gpv4jttu5toj/ListEvent.as?dl=0 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.dropbox.com%2Fs%2F6k0gpv4jttu5toj%2FListEvent.as%3Fdl%3D0&data=02%7C01%7Cpent%40adobe.com%7C77eaf9ccdebf4ab92dec08d594a1ceba%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636578345033407948&sdata=maByjmNUqKdz7Mx9kaNM3kQuDD%2B5Pg69YADDKdcXEpo%3D&reserved=0> What is the Alternate for itemRenderer? Thanks in Advance. Alina Kazi From: Alina Kazi [mailto:alina.k...@d-bz.com] Sent: Wednesday, March 28, 2018 4:05 PM To: users@royale.apache.org Subject: RE: Work on Emulation Hi Alex, I am trying to Create Emulation for mx\events\ListEvent I am sharing my code. Please correct me if anything is incorrect. Source Link for both flex and Royale ListEvent file: https://www.dropbox.com/s/ewogru08tut77cw/flexnRoyaleListEvent.zip?dl=0 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.dropbox.com%2Fs%2Fewogru08tut77cw%2FflexnRoyaleListEvent.zip%3Fdl%3D0&data=02%7C01%7Cpent%40adobe.com%7C77eaf9ccdebf4ab92dec08d594a1ceba%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636578345033407948&sdata=gsQhpapy7XWFkl2vE2sXSW1lOOl%2BkXrF4hyGvTrEiT4%3D&reserved=0> Thanks, Alina From: Alina Kazi [mailto:alina.k...@d-bz.com] Sent: Wednesday, March 28, 2018 2:24 PM To: users@royale.apache.org Subject: RE: Work on Emulation Hi , Like Alert, TitleWindow and extends Panel , Panel extends Container. I think I should start with a Basic Component. It is requested to All, put your name next to the component that is completed. Also when you start on a component, put your name next to it : Status(e.g. Completed) So, it will be easy for all of us to pick a new component and start working on it. https://github.com/apache/royale-asjs/issues/136 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fissues%2F136&data=02%7C01%7Cpent%40adobe.com%7C77eaf9ccdebf4ab92dec08d594a1ceba%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636578345033407948&sdata=dHOCRbtTkYv7BLzHrEzSOovUDLEM6TRT1qvGhCe8oos%3D&reserved=0> Thanks , Alina Kazi From: Alex Harui [mailto:aha...@adobe.com] Sent: Wednesday, March 28, 2018 12:50 PM To: users@royale.apache.org Subject: Re: Work on Emulation Please mark a component BEFORE you start working on it, not after you complete it. Otherwise more than one person might start working on a component. Maybe we can change the font once it is done or mark it some other way, but the main goal is to prevent duplication of work. Alina, feel free to start with Alert, but that might require doing Panel and TitleWindow first. Thanks, -Alex From: Piotr Zarzycki <piotrzarzyck...@gmail.com> Reply-To: "users@royale.apache.org" <users@royale.apache.org> Date: Wednesday, March 28, 2018 at 12:42 AM To: "users@royale.apache.org" <users@royale.apache.org> Subject: Re: Work on Emulation I have added checkboxes to each component. Once you finish work on specific component you can select it. 2018-03-28 8:49 GMT+02:00 Alina Kazi <alina.k...@d-bz.com>: Hi, Created a CheckBox Example and compiled it with Royale SDK Is it ok? https://www.dropbox.com/s/aihmei1sooq1ddr/CheckBoxExample.zip?dl=0 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.dropbox.com%2Fs%2Faihmei1sooq1ddr%2FCheckBoxExample.zip%3Fdl%3D0&data=02%7C01%7Caharui%40adobe.com%7C674df1a6f7734cb18bc208d5947f7749%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636578197540881722&sdata=1PnuBYC4cZi0QFve%2BOuA0Bt4JrCmZ9sAOAx%2BxeJgIFE%3D&reserved=0> -Alina Kazi From: Alina Kazi [mailto:alina.k...@d-bz.com] Sent: Wednesday, March 28, 2018 10:41 AM To: users@royale.apache.org Subject: RE: Work on Emulation Hi Peter, I tried emulation examples MXRoyale/HelloWorld and ControlsExample and compiled them successfully. Sure, I will create some examples definitely. Thank you. -Alina From: Peter Ent [mailto:p...@adobe.com] Sent: Tuesday, March 27, 2018 6:00 PM To: users@royale.apache.org Subject: Re: Work on Emulation Hi Alina, I'm working with Alex on the emulation examples. If you checkout the git repo branch, feature/MXRoyale, you will find all of our work so far. I am currently working on improving Button and Label. You could probably work to improve CheckBox. You will also find in that branch two examples: examples/MXRoyale/HelloWorld and ControlsExample. I've been using ControlsExample to test my items, so perhaps you could make a new example, like CheckBoxExample, to make it easier to focus on that component (just copy ControlsExample and then change the names). Thank you so much for your help. Regards, Peter Ent Adobe Systems/Apache Royale Project From: Alina Kazi <alina.k...@d-bz.com> Reply-To: "users@royale.apache.org" <users@royale.apache.org> Date: Tuesday, March 27, 2018 at 7:09 AM To: "users@royale.apache.org" <users@royale.apache.org> Subject: RE: Work on Emulation Hi Alex, Which file Should I take as an Example that is already ported to Apache Royale at initial stage to create emulation? e.g., flex https://github.com/apache/flex-sdk/blob/master/frameworks/projects/mx/src/mx/controls/CheckBox.as <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fflex-sdk%2Fblob%2Fmaster%2Fframeworks%2Fprojects%2Fmx%2Fsrc%2Fmx%2Fcontrols%2FCheckBox.as&data=02%7C01%7Cpent%40adobe.com%7Cee6709b0b33d40b111a208d593d32fb2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636577457600914057&sdata=d1fyl9v4GDrZDQjWT3N2F9ovCkP1TsHyAxJQ7%2BjyCkc%3D&reserved=0> royale https://github.com/apache/royale-asjs/blob/feature/MXRoyale/frameworks/projects/MXRoyale/src/main/royale/mx/controls/CheckBox.as <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fblob%2Ffeature%2FMXRoyale%2Fframeworks%2Fprojects%2FMXRoyale%2Fsrc%2Fmain%2Froyale%2Fmx%2Fcontrols%2FCheckBox.as&data=02%7C01%7Cpent%40adobe.com%7Cee6709b0b33d40b111a208d593d32fb2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636577457600914057&sdata=aobLCpOrxpP7eKLCydHjb%2FO0hr%2FeIbJ3KiwK6NGmc7w%3D&reserved=0> Thanks, Alina Kazi From: Alina Kazi [mailto:alina.k...@d-bz.com] Sent: Tuesday, March 27, 2018 3:28 PM To: users@royale.apache.org Subject: RE: Work on Emulation Hi Alex, I am ready to start work. Which Component should I start from the below given link : https://github.com/apache/royale-asjs/wiki/Emulation-Components <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fwiki%2FEmulation-Components&data=02%7C01%7Cpent%40adobe.com%7Cee6709b0b33d40b111a208d593d32fb2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636577457600914057&sdata=AoQE2O8bxvNu9%2BkKwUpaNsguTXefQRmVbKtjW0VvHd4%3D&reserved=0> If any Help/Guide/Example is Available other than the above given link. Please Share. Thanks in Advance. Alina Kazi From: Piotr Zarzycki [mailto:piotrzarzyck...@gmail.com] Sent: Wednesday, March 21, 2018 12:17 PM To: users@royale.apache.org Subject: Re: Work on Emulation Hi Alina, That is great news!!! Thanks, Piotr On Wed, Mar 21, 2018, 07:54 Alina Kazi <alina.k...@d-bz.com> wrote: Hi Alex, Our management has given another resource to work on Emulation. Once I will be able to release the Apache Royale build using Ant . Me & my Colleague We Both will learn & start working on Emulations This Thread We will use to Learn Emulation. Thanks, Alina Kazi -- Piotr Zarzycki Patreon: https://www.patreon.com/piotrzarzycki <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C674df1a6f7734cb18bc208d5947f7749%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636578197540881722&sdata=VSf0YUS26E8Jl3ev4yJyzqPCTJBanCmF%2Ful4kUuPAAE%3D&reserved=0> -- Piotr Zarzycki Patreon: https://www.patreon.com/piotrzarzycki -- Piotr Zarzycki Patreon: https://www.patreon.com/piotrzarzycki -- Piotr Zarzycki Patreon: https://www.patreon.com/piotrzarzycki -- Piotr Zarzycki Patreon: https://www.patreon.com/piotrzarzycki -- Piotr Zarzycki Patreon: https://www.patreon.com/piotrzarzycki
