Hi Carlos, How can I add my Pull Request to Emulation Components ?
and How can i change the status https://github.com/apache/royale-asjs/projects/4 To do -> In progress ->Done Thanks, Alina Kazi From: carlos.rov...@gmail.com [mailto:carlos.rov...@gmail.com] On Behalf Of Carlos Rovira Sent: Monday, April 09, 2018 7:06 PM To: users@royale.apache.org Subject: Re: Work on Emulation Hi Alina, I added some of your PRs to new project "Emulation Components", please if you create new add to this project so the tickets can be handler automatically. As well if you can configure for new (and old issues) the info in the right sidebar of GitHub, that would be of much help to better organize the effort thanks :) 2018-04-09 14:17 GMT+02:00 Alina Kazi <alina.k...@d-bz.com>: https://github.com/apache/royale-asjs/pull/157 for mx.core.EventPriority -Alina Kazi From: Alina Kazi [mailto:alina.k...@d-bz.com] Sent: Monday, April 09, 2018 4:45 PM To: users@royale.apache.org Subject: RE: Work on Emulation https://github.com/apache/royale-asjs/pull/156 for IViewCursor and ICollectionView -Alina Kazi From: Alina Kazi [mailto:alina.k...@d-bz.com] Sent: Monday, April 09, 2018 3:55 PM To: users@royale.apache.org Subject: RE: Work on Emulation Please review and/or comment on the changes in pull request For SandboxMouseEvent and ResizeEvent https://github.com/apache/royale-asjs/pull/155 Thanks in Advance J Alina Kazi From: Alina Kazi [mailto:alina.k...@d-bz.com] Sent: Monday, April 09, 2018 2:57 PM To: users@royale.apache.org Subject: RE: Work on Emulation Also review Pull Request for mx.effects.IEffectInstance and mx.events.EffectEvent https://github.com/apache/royale-asjs/pull/153 Thanks in Advance J Alina Kazi From: Alina Kazi [mailto:alina.k...@d-bz.com] Sent: Monday, April 09, 2018 12:04 PM To: users@royale.apache.org Subject: RE: Work on Emulation Could Someone Please Review these Pull Requests https://github.com/apache/royale-asjs/pull/150 https://github.com/apache/royale-asjs/pull/151 https://github.com/apache/royale-asjs/pull/152 Thanks in Advance J Alina Kazi From: Alina Kazi [mailto:alina.k...@d-bz.com] Sent: Monday, April 09, 2018 10:25 AM To: users@royale.apache.org Subject: RE: Work on Emulation Thanks Peter. From: Peter Ent [mailto:p...@adobe.com] Sent: Friday, April 06, 2018 7:59 PM To: users@royale.apache.org Subject: Re: Work on Emulation I merged these changes into the MXRoyale branch. They compiled cleanly. Great job! —peter From: Alina Kazi <alina.k...@d-bz.com> Reply-To: "users@royale.apache.org" <users@royale.apache.org> Date: Friday, April 6, 2018 at 6:56 AM To: "users@royale.apache.org" <users@royale.apache.org>, "d...@royale.apache.org" <d...@royale.apache.org> Subject: RE: Work on Emulation Please Review : https://github.com/apache/royale-asjs/pull/145 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F145&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=zcPe%2FP5GfVBjQADjvgZ0aba5uxIXwZEtyErETijQ8i8%3D&reserved=0> https://github.com/apache/royale-asjs/pull/149 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F149&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=GPKxD8qY%2Bjbo5aJu9Ws5a7fvy9NUF2rSy1WnpbSK%2Fxo%3D&reserved=0> Thanks, Alina Kazi From: Alina Kazi [mailto:alina.k...@d-bz.com] Sent: Friday, April 06, 2018 2:33 PM To: users@royale.apache.org Subject: RE: Work on Emulation Thanks Piotr. From: Piotr Zarzycki [mailto:piotrzarzyck...@gmail.com] Sent: Friday, April 06, 2018 12:32 PM To: users@royale.apache.org Subject: Re: Work on Emulation Hi Alina, One suggestion to the reporting in [1] - Could you please bold "in progress" status ? I just did for you now, but in the next which you will work please do so. It's much better visible. [1] https://github.com/apache/royale-asjs/issues/136 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fissues%2F136&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=gpILHV94aescQfiVffhg2qvJl8EZETzx%2FsiSUWsY9x0%3D&reserved=0> Thanks, Piotr 2018-04-06 9:28 GMT+02:00 Alina Kazi <alina.k...@d-bz.com>: Currently I am working on mx.collections.Sort and mx.collections.SortField from list. Dependencies Added : mx.collections.errors.SortError , mx.collections.ISort and mx.collections.ISortField are emulated as these API's were used in mx.collections.Sort and mx.collections.SortField. Dependencies Commented : mx.resources.IResourceManager and mx.resources.ResourceManager What are the alternative API's for import flash.system.ApplicationDomain; import flash.system.SecurityDomain; Pull Request : https://github.com/apache/royale-asjs/pull/148 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F148&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=AXamSfkxcP3Noeq03HlBtfEDoYDtRLwf8A6e4fExs3Y%3D&reserved=0> Thanks, Alina Kazi -----Original Message----- From: Alina Kazi [mailto:alina.k...@d-bz.com] Sent: Friday, April 06, 2018 10:57 AM To: users@royale.apache.org Subject: RE: Work on Emulation Sure, I will pick APIs from the List next time. Thanks, Alina Kazi -----Original Message----- From: Alex Harui [mailto:aha...@adobe.com] Sent: Wednesday, April 04, 2018 8:45 PM To: users@royale.apache.org Subject: Re: Work on Emulation Hi Alina, I am not seeing Tile in the list of APIs your application used. We should only be working on classes used by your app. Thanks, -Alex On 4/4/18, 8:03 AM, "Peter Ent" <p...@adobe.com> wrote: >Hi Alina, > >The CloseEvent looks fine. > >In the others, the [IconFile] needs to be removed. If you have removed >it I didn't see the deletion in the pull request. > >For Tile, I think that needs more work, unless I'm not reading the pull >request correctly. You should remove most of the contents of this file. >When we get to making Tile work, we have a Tile layout in Royale >already and chances the MX Tile will be implemented using the Royale >TileLayout. >But if not we can always go back and bring in code from the original >and re-work it then. > >Thanks, >Peter > >On 4/4/18, 6:15 AM, "Alina Kazi" <alina.k...@d-bz.com> wrote: > >>Branch->mxRoyaleTileandTileDirection >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyaleTileandTileDirection&data >>=02 >>% >>7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7 >>b34 >>4 >>38794aed2c178decee1%7C0%7C0%7C636584337418853728&sdata=ri9QIFg3k4H9Msm >>Yy0 >>c >>C48iy97u%2FZkSlAL0jPwlwoYE%3D&reserved=0 >>Pull Request >>:https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>om%2Fapache%2Froyale-asjs%2Fpull%2F143&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> >>%7C >>1 >>9e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0 >>%7C >>0 >>%7C636584337418853728&sdata=Q%2B%2FhMzYPx5Eklaicfgeo8p9S9EaAZfbMy6%2B0 >>UXc >>v >>b5s%3D&reserved=0 >>Tile.as >>TileDirection.as >> >>Branch->MxRoyaleCloseEvent >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Falinakazi%2Froyale-asjs%2Ftree%2FMxRoyaleCloseEvent&data=02%7C01%7 >>Cpe >>n >>t%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794a >>ed2 >>c >>178decee1%7C0%7C0%7C636584337418853728&sdata=JZ4a9VfDppcJkfQr%2BKivd9w >>GDk >>U >>cNHO7nDxJTXFAMus%3D&reserved=0 >>Pull Request >>:https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>om%2Fapache%2Froyale-asjs%2Fpull%2F144&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> >>%7C >>1 >>9e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0 >>%7C >>0 >>%7C636584337418853728&sdata=V%2FcBSzGeei7i0YNTIZoEnVKJbi18DtVLv%2BV%2F >>2vY >>7 >>HA4%3D&reserved=0 >>CloseEvent.as >> >>Branch->mxRoyaleScrollPolicynControlBar >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyaleScrollPolicynControlBar&d >>ata >>= >>02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b >>5a7 >>b >>34438794aed2c178decee1%7C0%7C0%7C636584337418853728&sdata=sWHbuXAg4aDM >>ef7 >>% >>2B56eYCTvktJzqI13HmFapcTzhcn8%3D&reserved=0 >>Pull Request >>:https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>om%2Fapache%2Froyale-asjs%2Fpull%2F145&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> >>%7C >>1 >>9e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0 >>%7C >>0 >>%7C636584337418853728&sdata=rlggrlP1C%2BlCX07dIgA2sGoIJvA%2Frc2zleh267 >>ZN5 >>N >>M%3D&reserved=0 >>ScrollPolicy.as >>ControlBar.as >> >>Please Review. >> >>Thanks, >>Alina Kazi >> >>-----Original Message----- >>From: Alina Kazi [mailto:alina.k...@d-bz.com] >>Sent: Wednesday, April 04, 2018 12:06 PM >>To: users@royale.apache.org >>Subject: RE: Work on Emulation >> >>Hi Alex, >> >>Tile and Tile Direction are ready for Review. >>And Now, I am working on CloseEvent. >> >>Thanks, >>Alina >>-----Original Message----- >>From: Alex Harui [mailto:aha...@adobe.com] >>Sent: Wednesday, April 04, 2018 11:14 AM >>To: users@royale.apache.org >>Subject: Re: Work on Emulation >> >>Hi Alina, >> >>Peter meant that the changing of mx_internal to protected was only >>temporary. mx_internal should be working for Royale so please use >>mx_internal instead of protected. Using protected may cause other >>things to not work. >> >>Thanks, >>-Alex >> >>From: Alina Kazi <alina.k...@d-bz.com> >>Reply-To: "users@royale.apache.org" <users@royale.apache.org> >>Date: Tuesday, April 3, 2018 at 10:36 PM >>To: "users@royale.apache.org" <users@royale.apache.org> >>Subject: RE: Work on Emulation >> >> >>Thanks. >>replaced mx_internal with protected for now. >>And Tile and TileDirection are compiled Successfully without any warning. >> >>Alina Kazi >> >> >>From: Peter Ent [mailto:p...@adobe.com] >> >>Sent: Tuesday, April 03, 2018 5:33 PM >>To: users@royale.apache.org >>Subject: Re: Work on Emulation >> >> >> >>I recommended changing mx_internal to protected as a stop-gap. I knew >>Alex would be putting something out for MXRoyale. >> >> >> >>Also: please update the Github issue with your progress. I've been >>trying to be consistent using it as more people working on the same >>items will be confusing. >> >> >> >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Fapache%2Froyale-asjs%2Fissues%2F136&data=02%7C01%7Cpent%40adobe.co >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.co&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=xATrWRDEj0YWKchFU7LzpDNYvgNRV9ykkVLJR1KXsnY%3D&reserved=0> >> >>m%7 >>C >>19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C >>0%7 >>C >>0%7C636584337418853728&sdata=EhaUCaU3xuzqoQv0CnEpILTCx%2BeCa2qDuOD9Q%2 >>BeP >>q >>C8%3D&reserved=0 >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>o >>m%2Fapache%2Froyale-asjs%2Fissues%2F136&data=02%7C01%7Caharui%40adobe. >>com >>% >>7 >>Ca8619ad543114ced36b508d599ee2969%7Cfa7b1b5a7b34438794aed2c178decee1%7 >>C0% >>7 >>C >>0%7C636584170597362200&sdata=5Nzq5hj1BwKn8tvGMUcb8Z6FIA0hlg2KQx%2BhpsD >>RPd >>c >>% >>3D&reserved=0> >> >> >> >>Thanks. >> >>Peter >> >> >> >>From: >>Piotr Zarzycki <piotrzarzyck...@gmail.com> >>Reply-To: "users@royale.apache.org" <users@royale.apache.org> >>Date: Tuesday, April 3, 2018 at 8:26 AM >>To: "users@royale.apache.org" <users@royale.apache.org> >>Subject: Re: Work on Emulation >> >> >> >>Hi Alina, >> >> >> >>If it is mx_internal I see suggestion to change it to some >>protected/private ? I'm not sure about that, but the other way is to >>got with suggestion - create getter/setter. >> Alex also in his suppress warnings in that commits [1] >> >> >> >>[1] >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Fapache%2Froyale-asjs%2Fcommit%2F3cfa84f95635df16e5f6b8214b483a&dat >>a=0 >>2 >>%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a >>7b3 >>4 >>438794aed2c178decee1%7C0%7C0%7C636584337418853728&sdata=6aLKAVHE6Y5iL4 >>OAw >>8 >>mEHAZ5gtLABpDocDo5Jyskiqo%3D&reserved=0 >>e4c68a902c >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>o >>m%2Fapache%2Froyale-asjs%2Fcommit%2F3cfa84f95635df16e5f6b8214b483ae4c6 >>8a9 >>0 >>2 >>c&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C679c7e10e41d48c27a3908d5995e21d8%7 >>Cfa >>7 >>b >>1b5a7b34438794aed2c178decee1%7C0%7C0%7C636583551935678296&sdata=hUZODG >>ygt >>u >>u >>b%2BmqBixRZEd0XNL0UcTlTA0h43nGoFb0%3D&reserved=0> >> >> >> >>Thanks, >> >>Piotr >> >> >> >>2018-04-03 14:22 GMT+02:00 Alina Kazi <alina.k...@d-bz.com>: >>Thanks Alex >>Now I am working on : Tile and TileDirection >>Both files are compiled successfully after changes Pull Request : >> >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Fapache%2Froyale-asjs%2Fpull%2F143&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> % >>7C1 >>9 >>e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0% >>7C0 >>% >>7C636584337418853728&sdata=Q%2B%2FhMzYPx5Eklaicfgeo8p9S9EaAZfbMy6%2B0U >>Xcv >>b >>5s%3D&reserved=0 >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>o >>m%2Fapache%2Froyale-asjs%2Fpull%2F143&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> % >>7C6 >>7 >>9 >>c7e10e41d48c27a3908d5995e21d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7 >>C0% >>7 >>C >>636583551935678296&sdata=lla5d0d7ftNbP7MhPqKYHjwhn8uxAjXdHLPyGvVrTHo%3 >>D&r >>e >>s >>erved=0> >> >>Only a Warning in Tile.as >> >>What I should do to remove that warning [java] >>D:\outtest\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\ >>mx\containers\Tile.as(277): col: 5 public var may not work in minified >>JS output . Use getter/setter instead. >> [java] >> [java] mx_internal var cellWidth:Number; >> >>Thanks, >>Alina Kazi >>From: Alex >> Harui [mailto:aha...@adobe.com] >> >>Sent: Tuesday, April 03, 2018 12:27 PM >> >>To: users@royale.apache.org >>Subject: Re: Work on Emulation >> >> >> >> >> >>Hi Alina, >> >> >> >>Congratulations! I merged your pull request. You have now >>contributed code to Apache Royale. >> >> >> >>You should be able to use mx_internal now. I pushed those changes >>earlier. >> >> >> >>I'm done for today, hopefully Peter or Piotr will review the >>Hrule/Vrule pull request. Please make sure there are no warnings in >>the build. I updated ListEvent and SliderEvent to suppress warnings. >> >> >> >>Thanks, >> >>-Alex >> >> >> >>From: >>Alina Kazi <alina.k...@d-bz.com> >>Reply-To: "users@royale.apache.org" <users@royale.apache.org> >>Date: Monday, April 2, 2018 at 11:25 PM >>To: "users@royale.apache.org" <users@royale.apache.org> >>Subject: RE: Work on Emulation >> >> >> >>Thanks alot Peter and Alex. >>HRule and VRule Files are added to new Branch and Compiled >>Successfully >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Falinakazi%2Froyale-asjs%2Ftree%2Falinakazi-HRuleVRule%2Fframewor&d >>ata >>= >>02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b >>5a7 >>b >>34438794aed2c178decee1%7C0%7C0%7C636584337418853728&sdata=KqF8DsxJLOED >>LeY >>D >>Q4V1Jvb4KToKq43jAGIaK%2F3UbUw%3D&reserved=0 >>ks/projects/MXRoyale/src/main/royale/mx/controls >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>o >>m%2Falinakazi%2Froyale-asjs%2Ftree%2Falinakazi-HRuleVRule%2Fframeworks >>%2F >>p >>r >>ojects%2FMXRoyale%2Fsrc%2Fmain%2Froyale%2Fmx%2Fcontrols&data=02%7C01%7 >>Cah >>a >>r >>ui%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7Cf803a2f5bfae4b51df5508d5992bc5ff%7Cfa7b1b5a7b34438794 >>aed >>2 >>c >>178decee1%7C0%7C0%7C636583335664948195&sdata=0wAuwW7NcLkLbUw6yQkidChhJ >>5t7 >>s >>x >>VR9aDt%2Fdqcbm0%3D&reserved=0> >> >>In Panel : I will also replace ³mx_internal³ with "protected" >> >>And comment-out all functions and/or variables that referencing >>something not yet ported. >> >>Alina Kazi >>From: Alex >> Harui [mailto:aha...@adobe.com] >> >>Sent: Monday, April 02, 2018 8:28 PM >>To: users@royale.apache.org >>Subject: Re: Work on Emulation >> >> >> >>Hi Alina, >> >> >> >>mx_internal methods may not need to be ported. If they are not listed >>in the list of API s you used in your app, the next question is >>whether they are needed to emulate the functionality of the component >>that you do use. In many cases they are not needed. >> >> >> >>I am working on getting mx_internal working on the JS side. Even >>though mx_internal APIs are not supported by Flex, I don't doubt that >>other namespaces are used somewhere so we should try to get it to >>work. It has been working in simple test cases so not sure yet why it >>isn't working in the emulation components. >> >> >> >>Thanks, >> >>-Alex >> >> >> >>From: >>Peter Ent <p...@adobe.com> >>Reply-To: "users@royale.apache.org" <users@royale.apache.org> >>Date: Monday, April 2, 2018 at 7:06 AM >>To: "users@royale.apache.org" <users@royale.apache.org> >>Subject: Re: Work on Emulation >> >> >> >>Hi Alina, >> >> >> >>Sorry for the delayed response. >> >> >> >>First, try to port over something easier like VRule and HRule as a >>first step since these are less complex. >> >> >> >>As for mx_internal - I have been changing these to "protected". >> >> >> >>Once you do that you'll find that you will also need IUITextField. I >>haven't done that but I just took a look at it. You can do a couple >>of >>things: >> >> >> >>In Panel (and any where else), comment-out any function or variable >>that references something not yet ported. We are trying to pass >>compilation, so that would be OK at this stage. >> >> >> >>If you feel you need to bring something else over, then you have to go >>through the same process of course. Since you can wind up following >>class and interface down a long chain, I would just comment-out things >>complex. Sometimes I am left with "implements IUIComponent" and the >>rest of the interfaces listed in a class are put into comments. >> >> >> >>I hope that helps. >> >>‹peter >> >> >> >>From: >>Alina Kazi <alina.k...@d-bz.com> >>Reply-To: "users@royale.apache.org" <users@royale.apache.org> >>Date: Monday, April 2, 2018 at 7:43 AM >>To: "users@royale.apache.org" <users@royale.apache.org> >>Subject: RE: Work on Emulation >> >> >> >>mx.containers.Panel >> >>Panel.as file contains many variables and methods that are using >>mx_internal e.g. Variable >> mx_internal var _showCloseButton:Boolean = false; >> >>Method >> mx_internal function getStatusTextField():IUITextField >> { >> return statusTextField; >> } >>As use namespace mx_internal; and import mx.core.mx_internal; are >>commented in source files . >>I am getting errors on these variables and methods e.g. >> [java] >>D:\out\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\con >>tai >>n >>e >>rs\Panel.as(1796): >> >>col: 6 function 'getStatusTextField' will be scoped to the default >>namespace: mx.containers.Panel: >> internal. >>It will not be visible outside of this package. >> [java] >> [java] function getStatusTextField():IUITextField >> >> >>Should I comment all of these variables and methods ? >> >>Or >>Should I make all of these variables and methods Public? >> >>For Reference, I am sharing link. So you don't need to find this file >>in flex-sdk , You can find the at: >>Flex-sdk mx.containers.Panel: >> >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.d >>rop >>b >>ox.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fox.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=o0IG2SUHlSgYxNATHq5JyDJFTYvGrxy7ij6D5fo6L4A%3D&reserved=0> >> %2Fs%2F6xb1jp2efwuwnam%2FPanelFlex.as%3Fdl%3D0&data=02%7C01%7Cpe >>nt% >>4 >>0adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F0adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=2VfwjDjvNkCNplKZHSwj3a0wXKWQDCJcop9uD%2BBVfU4%3D&reserved=0> >> %7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2 >>c17 >>8 >>decee1%7C0%7C0%7C636584337418853728&sdata=gu%2BhySrmf%2FUKFngpLQzeWcRO >>CfK >>e >>%2FxzorPgxOHjwqis%3D&reserved=0 >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww. >>dro >>p >>b >>ox.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fox.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=o0IG2SUHlSgYxNATHq5JyDJFTYvGrxy7ij6D5fo6L4A%3D&reserved=0> >> %2Fs%2F6xb1jp2efwuwnam%2FPanelFlex.as%3Fdl%3D0&data=02%7C01%7Cpe >>nt% >>4 >>0 >>adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fadobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=M3lUEkvW7h4RemEKaVUqPddFeCLOUsVFEIpXN6Rc%2FFU%3D&reserved=0> >> %7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c >>178 >>d >>e >>cee1%7C0%7C0%7C636582662509500604&sdata=xLjL8AM45ZA2E8IRILbskD04cJCL9S >>VSc >>5 >>F >>i0%2BO98Tg%3D&reserved=0> >>Royale >>:https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>om%2Falinakazi%2Froyale-asjs%2Fblob%2FmxRoyalePanel%2Fframeworks%2Fpro >>&da >>t >>a=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b >>1b5 >>a >>7b34438794aed2c178decee1%7C0%7C0%7C636584337418863731&sdata=a8xVdkw2mn >>wSo >>j >>xLoUJiZmOIN0SxdeqviB%2By5AbaSl4%3D&reserved=0 >>jects/MXRoyale/src/main/royale/mx/containers/Panel.as >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>o >>m%2Falinakazi%2Froyale-asjs%2Fblob%2FmxRoyalePanel%2Fframeworks%2Fproj >>ect >>s >>% >>2FMXRoyale%2Fsrc%2Fmain%2Froyale%2Fmx%2Fcontainers%2FPanel.as&data=02% >>7C0 >>1 >>% >>7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b3443 >>879 >>4 >>a >>ed2c178decee1%7C0%7C0%7C636582662509500604&sdata=Zwbl%2B2eMeQIsuoDCI4m >>fZ1 >>A >>4 >>TF3cA%2FcSqlzq53DEO5Y%3D&reserved=0> >> >>Thanks in Advance. >>Alina >> >>From: Alina >> Kazi [mailto:alina.k...@d-bz.com] >> >>Sent: Monday, April 02, 2018 3:25 PM >>To: users@royale.apache.org >>Subject: RE: Work on Emulation >> >> >> >> >>Thanks >>J >>New branch Created : >> >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyalePanel&data=02%7C01%7Cpent >>%40 >>a >>dobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=bqNf4OYFIciJ0OGu%2BELGSrAnnWz6UuqA%2Bbtg6NOl3ZU%3D&reserved=0> >> %7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c1 >>78d >>e >>cee1%7C0%7C0%7C636584337418863731&sdata=e43MWXidxAVYCz6uJEwPWPigWnXnlK >>pgh >>0 >>012hW2VmA%3D&reserved=0 >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>o >>m%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyalePanel&data=02%7C01%7Cpent >>%40 >>a >>d >>obe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=mtuOnFgtK%2BOTE5EgamElD3xzS64EaZ%2FCv5cYMgJ%2Fa7w%3D&reserved=0> >> %7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c17 >>8de >>c >>e >>e1%7C0%7C0%7C636582662509500604&sdata=AbVDtIurdRp7fwqDGrLxUrQqYXv8EvuT >>wCD >>w >>7 >>%2BWMBtc%3D&reserved=0> >> >>Copied MX Panel from flex-sdk to New branch (mxRoyalePanel) Pull >>Request >>: >> >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Fapache%2Froyale-asjs%2Fpull%2F141&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> % >>7C1 >>9 >>e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0% >>7C0 >>% >>7C636584337418863731&sdata=0%2Br4jSVY%2B3WoupxT%2BxU8noG6M3ZuN2labOIcd >>B%2 >>F >>t9%2FY%3D&reserved=0 >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>o >>m%2Fapache%2Froyale-asjs%2Fpull%2F141&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> % >>7C8 >>1 >>6 >>60be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7 >>C0% >>7 >>C >>636582662509500604&sdata=sVStAHTosnX0lBpTYWRCEC23BiiVaX8t1%2F08YICYjOs >>%3D >>& >>r >>eserved=0> >> >>-Alina Kazi >> >> >>From: Piotr >> Zarzycki [mailto:piotrzarzyck...@gmail.com] >> >>Sent: Monday, April 02, 2018 1:22 PM >>To: users@royale.apache.org >>Subject: Re: Work on Emulation >> >>Alina, >> >> >>You cannot delete pull request. You can only close it, so we are good >>with >>139 and 140. They are closed. >> >> >> >>Your pull request 138 now looks great! :) >> >> >> >>Whenever you are going to push some bigger changes you should create >>new branches. If you are working right now on Panel - probably new >>branch with your changes would be the best. Our pull request will >>looks than cleaner. - That is just my recommendation. >> >> >> >>In general congrats for your first pull request to Apache Royale >>project!! >>:) >> >> >> >>Thanks, >> >>Piotr >> >> >> >>2018-04-02 8:08 GMT+02:00 Alina Kazi <alina.k...@d-bz.com>: >>Hi Piotr, >> >>Thanks Piotr. >> >>I am trying to add another pull request for SliderEvent.as file. but >>when I added this file manually at >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyaleAQ%2Fframeworks%2Fproject >>&da >>t >>a=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b >>1b5 >>a >>7b34438794aed2c178decee1%7C0%7C0%7C636584337418863731&sdata=nQ1Yt%2FwJ >>xyU >>U >>ybkTdCMHxgoxZ%2BaqMXv9gOJFXqo1agQ%3D&reserved=0 >>s >>/MXRoyale/src/main/royale/mx/events >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>o >>m%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyaleAQ%2Fframeworks%2Fproject >>s%2 >>5 >>0 >>d%250a%2FMXRoyale%2Fsrc%2Fmain%2Froyale%2Fmx%2Fevents&data=02%7C01%7Cp >>ent >>% >>4 >>0adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F0adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=2VfwjDjvNkCNplKZHSwj3a0wXKWQDCJcop9uD%2BBVfU4%3D&reserved=0> >> %7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2 >>c17 >>8 >>d >>ecee1%7C0%7C0%7C636582662509500604&sdata=rhi6Z0g%2B6UCXr%2Btgp5gpKFrmd >>aaj >>q >>Y >>LlmTh7iNvdoCU%3D&reserved=0> >>and commit it. >>Commit auto added to previous Pull Request : >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Fapache%2Froyale-asjs%2Fpull%2F138&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> % >>7C1 >>9 >>e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0% >>7C0 >>% >>7C636584337418863731&sdata=pqviRdd4rBRgwqPalenRjO5HljItXWOLVQXHtbvvle0 >>%3D >>& >>reserved=0 >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>o >>m%2Fapache%2Froyale-asjs%2Fpull%2F138&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> % >>7C8 >>1 >>6 >>60be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7 >>C0% >>7 >>C >>636582662509500604&sdata=a1%2BNp%2Ft3M7aSPIwqN%2BQt7XY50OX%2BSwRDB%2FA >>CRJ >>h >>W >>LH4%3D&reserved=0> >> >>Is it ok to do multiple commits on same pull Request instead of >>creating New Pull Request for each file? >> >>How Can I delete these Closed Pull Requests? >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Fapache%2Froyale-asjs%2Fpull%2F139&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> % >>7C1 >>9 >>e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0% >>7C0 >>% >>7C636584337418863731&sdata=O%2BQydj0NU08TgdGr8jlB%2B5XAWpOm43BMhggA6O7 >>OlL >>Q >>%3D&reserved=0 >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>o >>m%2Fapache%2Froyale-asjs%2Fpull%2F139&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> % >>7C8 >>1 >>6 >>60be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7 >>C0% >>7 >>C >>636582662509500604&sdata=apy1DAJqmHGIjCdQDz4g0K36NbZATtHhA%2Foqc659Bjs >>%3D >>& >>r >>eserved=0> >>and >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Fapache%2Froyale-asjs%2Fpull%2F140&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> % >>7C1 >>9 >>e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0% >>7C0 >>% >>7C636584337418863731&sdata=6eljm%2FuiMELY9NLSm3lt9mV3%2BfInbFfsAWuo4ZZ >>UMS >>M >>%3D&reserved=0 >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>o >>m%2Fapache%2Froyale-asjs%2Fpull%2F140&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> % >>7C8 >>1 >>6 >>60be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7 >>C0% >>7 >>C >>636582662509500604&sdata=XehX29ItsGAwo33xue7KI9uD4PEJS3gGhS7ad1E7iSk%3 >>D&r >>e >>s >>erved=0> >> >> >>-Alina >> >> >> >>-----Original Message----- >>From: piotrz [mailto:pio...@apache.org] >>Sent: Friday, March 30, 2018 5:14 PM >>To: >>users@royale.apache.org <mailto:users@royale.apache.org> >>Subject: Re: Work on Emulation >>I see your new pull request and it doesn't looks good. [1] As you can >>see on the screenshot you did it against develop from feature/MXRoyale >>and it contains 94 commits. >> >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapach >>e-r >>o >>yale-users.20374.n8.nabble.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fyale-users.20374.n8.nabble.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=%2FT3CFWQA8u%2FTtdoVjkJVW%2B4wuugGWthAJ5FpGnGYQPc%3D&reserved=0> >> %2Ffile%2Ft1%2Fnew_pull_request.pn >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Frequest.pn&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=N%2Bsq%2BVUX6VTSXkFaQvVHy%2FNTVpj6YjrtXoOY82Qrabo%3D&reserved=0> >> &data= >>02% >>7 >>C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b >>344 >>3 >>8794aed2c178decee1%7C0%7C0%7C636584337418863731&sdata=rHNZfTbTa2Z8iLXt >>slP >>o >>gffyHAy%2B76ZnN7AgZytmsSw%3D&reserved=0 >>g >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapach >>e-r >>o >>y >>ale-users.20374.n8.nabble.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fale-users.20374.n8.nabble.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=kQDZN2LR2HoCcGIlhZm%2BGGwf4ldcFJhSkusV1v%2Bj1fY%3D&reserved=0> >> %2Ffile%2Ft1%2Fnew_pull_request.png&data= >>02% >>7 >>C >>01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b3 >>443 >>8 >>7 >>94aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=O0UU8UF57g%2BxBjEm >>1BU >>% >>2 >>BDdoyAqaNEMxwl%2FQijXxEDKQ%3D&reserved=0> >>> >> >>The old one is being done correctly. You have used your branch -> >>apache:feature/MXRoyale from alinakazi:mxRoyaleAQ >> >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapach >>e-r >>o >>yale-users.20374.n8.nabble.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fyale-users.20374.n8.nabble.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=%2FT3CFWQA8u%2FTtdoVjkJVW%2B4wuugGWthAJ5FpGnGYQPc%3D&reserved=0> >> %2Ffile%2Ft1%2Fold_pull_Request.pn&data= >>02% >>7 >>C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b >>344 >>3 >>8794aed2c178decee1%7C0%7C0%7C636584337418863731&sdata=Q1RLtZlGQgzJ3ZIG >>Y3I >>P >>zf168%2BcwK2RY5I4agLcLnK0%3D&reserved=0 >>g >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapach >>e-r >>o >>y >>ale-users.20374.n8.nabble.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fale-users.20374.n8.nabble.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=kQDZN2LR2HoCcGIlhZm%2BGGwf4ldcFJhSkusV1v%2Bj1fY%3D&reserved=0> >> %2Ffile%2Ft1%2Fold_pull_Request.png&data= >>02% >>7 >>C >>01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b3 >>443 >>8 >>7 >>94aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=wY1dxwYu%2B2G%2Be3 >>czh >>r >>a >>yFYw7FGgBmQIqic7v26mzqEk%3D&reserved=0> >>> >> >>[1] >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu >>b.c >>o >>m%2Fapache%2Froyale-asjs%2Fpull%2F139%2Fcommits&data=02%7C01%7Cpent%40 >>ado >>b >>e.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=aJFV4y7TXpbfAMLAbQpO%2FTO4cPiJ5hWMYGisG%2Fr9FJc%3D&reserved=0> >> %7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178d >>ece >>e >>1%7C0%7C0%7C636584337418863731&sdata=T002sFfbImGVBpkSiCiHDrfobQS9vAhgE >>nZ4 >>i >>jOJq9A%3D&reserved=0 >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>c >>o >>m%2Fapache%2Froyale-asjs%2Fpull%2F139%2Fcommits&data=02%7C01%7Cpent%40 >>ado >>b >>e >>.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178de >>cee >>1 >>% >>7C0%7C0%7C636582662509500604&sdata=HUrVPryVBIrheFbS%2BzRap%2BPpOrVETRJ >>B%2 >>F >>h >>630nCVWPo%3D&reserved=0> >> >>Thanks, >>Piotr >> >> >> >>-- >>Sent from: >>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache >>-ro >>y >>ale-users.20374.n8.nabble.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fale-users.20374.n8.nabble.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=kQDZN2LR2HoCcGIlhZm%2BGGwf4ldcFJhSkusV1v%2Bj1fY%3D&reserved=0> >> %2F&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C19e >>627 >>1 >>d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7 >>C63 >>6 >>584337418863731&sdata=HZlkRMQseCJzWNErp9aIFkPVDXSfLN1wJgcwLdil%2FT4%3D >>&re >>s >>erved=0 >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapach >>e-r >>o >>y >>ale-users.20374.n8.nabble.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fale-users.20374.n8.nabble.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=kQDZN2LR2HoCcGIlhZm%2BGGwf4ldcFJhSkusV1v%2Bj1fY%3D&reserved=0> >> %2F&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C816 >>60b >>e >>1 >>d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C >>636 >>5 >>8 >>2662509500604&sdata=pfDAW81u489DuWy0Gc80ll1HzseZk5gMhoneBuYpCJQ%3D&res >>erv >>e >>d >>=0> >> >> >> >> >> >> >> >> >>-- >> >>Piotr Zarzycki >>Patreon: >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p >>atr >>e >>on.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fon.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=r8DOztOKJYlPuLlxBxJmA%2Fjaz9yQidB9Ucdt0JH1fyI%3D&reserved=0> >> %2Fpiotrzarzycki&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C19e6271d08cd4 >>b9a >>b >>e1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636584337 >>418 >>8 >>63731&sdata=%2BKhmm2BcQez99eBDaV5OOy%2BzAbRWku6eP318jSrVAAU%3D&reserve >>d=0 >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww. >>pat >>r >>e >>on.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fon.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=r8DOztOKJYlPuLlxBxJmA%2Fjaz9yQidB9Ucdt0JH1fyI%3D&reserved=0> >> %2Fpiotrzarzycki&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C81660be1d8504 >>eff >>c >>1 >>6c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365826625 >>095 >>0 >>0 >>604&sdata=7xFAD19Wk39S%2BJEn6QB6jibV8%2B7Y9O8Ee16CAVyZPTk%3D&reserved= >>0> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >>-- >> >>Piotr Zarzycki >>Patreon: >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p >>atr >>e >>on.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fon.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=r8DOztOKJYlPuLlxBxJmA%2Fjaz9yQidB9Ucdt0JH1fyI%3D&reserved=0> >> %2Fpiotrzarzycki&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C19e6271d08cd4 >>b9a >>b >>e1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636584337 >>418 >>8 >>63731&sdata=%2BKhmm2BcQez99eBDaV5OOy%2BzAbRWku6eP318jSrVAAU%3D&reserve >>d=0 >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww. >>pat >>r >>e >>on.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fon.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=r8DOztOKJYlPuLlxBxJmA%2Fjaz9yQidB9Ucdt0JH1fyI%3D&reserved=0> >> %2Fpiotrzarzycki&data=02%7C01%7Cpent%40adobe.com >><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0> >> %7C679c7e10e41d4 >>8c2 >>7 >>a >>3908d5995e21d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365835519 >>356 >>7 >>8 >>296&sdata=ouHh9HJGSsN0f2%2B7vw5GDz2bcplJFMmO1DDodVy9%2BNo%3D&reserved= >>0> >> >> >> > -- Piotr Zarzycki Patreon: https://www.patreon.com/piotrzarzycki <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=Ck9yLwxMUCVN9L8oeAhHKKaPOHYHY0x6qFa6zn4hfMk%3D&reserved=0> -- Carlos Rovira http://about.me/carlosrovira
