Yes, I just compiled and everything works as expected. Does anyone see any problems with making the change? [#214]
[#214] https://github.com/apache/royale-compiler/pull/214/commits/8b1d1879de297eea6a9b6578dde8f571f63af148 Hiedra De: Alex Harui <aha...@adobe.com> Enviado el: viernes, 27 de mayo de 2022 1:30 Para: users@royale.apache.org Asunto: Re: Incomplete CSS I think that’s correct. I would have to examine more source to be more sure, but my time is limited right now. Probably best to try adding something and see if it makes a difference. Good luck, -Alex From: Maria Jose Esteve <mjest...@iest.com> Reply-To: "users@royale.apache.org" <users@royale.apache.org> Date: Thursday, May 26, 2022 at 4:26 PM To: "users@royale.apache.org" <users@royale.apache.org> Subject: RE: Incomplete CSS Alex, I will sleep one hour less today ☹ but you gave me a good hint 😝 I wanted to follow. I think I found the selector type list: $ROYALE_COMPILER_HOME$\compiler-jx\src\main\java\org\apache\royale\compiler\internal\driver\js\royale\ JSCSSCompilationSession.java Line 293: List<String> htmlElementNames = Arrays.asList( "a", "aside", "b", "br", … "u", "ul" ); Am I in the right place? Hiedra De: Alex Harui <aha...@adobe.com> Enviado el: jueves, 26 de mayo de 2022 23:09 Para: users@royale.apache.org Asunto: Re: Incomplete CSS IIRC, the list of standard type selectors is somewhere else in the compiler that won’t require antlr (just Java). I don’t have time right now to go look for it. Search the compiler for some old type selector names like “button” and “select” and “input” but you might get hits elsewhere. HTH, -Alex From: Maria Jose Esteve <mjest...@iest.com<mailto:mjest...@iest.com>> Reply-To: "users@royale.apache.org<mailto:users@royale.apache.org>" <users@royale.apache.org<mailto:users@royale.apache.org>> Date: Thursday, May 26, 2022 at 2:05 PM To: "users@royale.apache.org<mailto:users@royale.apache.org>" <users@royale.apache.org<mailto:users@royale.apache.org>> Subject: RE: Incomplete CSS > I think Royale does have a list of standard type selectors it will include in > the output, but that list might need updating to include “mark”. I have started to look at antlr (as you commented me some time ago), maybe in 100 years I will get clear, and I can modify it 😝 . In the meantime, I have an auxiliary defaults.css, which I reference directly in the html template, where I put all the styles that are not yet supported. Thx Hiedra De: Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>> Enviado el: jueves, 26 de mayo de 2022 21:26 Para: users@royale.apache.org<mailto:users@royale.apache.org> Asunto: Re: Incomplete CSS Royale (and Flex) compilers have special handling for CSS Type Selectors. Default values are provided in non-standard Type Selectors. If a type is not used in the compilation, those Type Selectors are not included in the output. I think Royale does have a list of standard type selectors it will include in the output, but that list might need updating to include “mark”. HTH, -Alex From: Maria Jose Esteve <mjest...@iest.com<mailto:mjest...@iest.com>> Reply-To: "users@royale.apache.org<mailto:users@royale.apache.org>" <users@royale.apache.org<mailto:users@royale.apache.org>> Date: Wednesday, May 25, 2022 at 9:24 AM To: "users@royale.apache.org<mailto:users@royale.apache.org>" <users@royale.apache.org<mailto:users@royale.apache.org>> Subject: RE: Incomplete CSS In principle no, because it refers to an HTML <mark> Tag [1] (like h1, h3, input, ...), it is not a class. "I have tried it too" and although it does transfer it to App.css it does not work because it is not recognized as the <mark> tag ☹ [1] https://www.w3schools.com/tags/tag_mark.asp<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.w3schools.com%2Ftags%2Ftag_mark.asp&data=05%7C01%7Caharui%40adobe.com%7C2e420ff324b14adfc7d508da3f6f2208%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637892043798169109%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BqxGbUOtkzhP1Z8CKupPmuM2yLoZeJzZM3dJRqSpumY%3D&reserved=0> Hiedra De: Andrew Wetmore <cottag...@gmail.com<mailto:cottag...@gmail.com>> Enviado el: miércoles, 25 de mayo de 2022 15:15 Para: users@royale.apache.org<mailto:users@royale.apache.org> Asunto: Re: Incomplete CSS Is "mark" missing the period at the start of the name? On Wed, May 25, 2022 at 8:44 AM Maria Jose Esteve <mjest...@iest.com<mailto:mjest...@iest.com>> wrote: Hi, I find myself with a problem that I don't know how to solve, and I thought that, perhaps, some of you have also suffered from it... it is also possible that I am doing it wrong... I have in defaults.css, of the application, all the custom styles: own styles of the application or customizations of styles established in components of some library. The problem is that it moves "some of these css's" to App.css and not others. Ex: .vscomp-wrapper { font-family: 'Open Sans', serif, sans-serif !important; color: #333333 !important; } mark { background-color: #04a3b3; color: #fff; } .vscomp-royale { background-color: #333333 !important; color: #04a3b3 !important; } .jewel.drawer .drawermain { background-color: #333333 !important; border-left: 0; display: inline-flex; …; } Of these 4 styles all of them are transferred to App.css except for "mark", do you have any idea what the reason might be? Thx. Hiedra -- Andrew Wetmore Editor, Moose House Publications<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmoosehousepress.com%2F&data=05%7C01%7Caharui%40adobe.com%7C2e420ff324b14adfc7d508da3f6f2208%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637892043798169109%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=e%2BWYgZWIFwzx7m4fwQwSzeJpYSxe%2BH2HVPl1h7GY%2Fnk%3D&reserved=0> Editor-Writer, The Apache Software Foundation<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapache.org%2F&data=05%7C01%7Caharui%40adobe.com%7C2e420ff324b14adfc7d508da3f6f2208%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637892043798169109%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Qk3v7AJYlsfWX%2FZjHpCokmphK7eE8WG9d4WAni1pjf8%3D&reserved=0>
