Hi, Am Donnerstag, den 03.03.2011, 17:07 +0000 schrieb Carl Hall: > There seem to be 3 things to accomplish here: > * Change logging order to have slf4j write into the LogService then have a > LogListener that will handle writing to logback, etc.
I would not do that. Rather keep the structure as it is now. Maybe we can just provide a custom logback appender which emits the OSGi events requested by Bertrand ? > * Replace homegrown log mechanism with logback (or something comparable) > * maintaining all current functionality. +1 to both. > > And while I'm buying cycles I might as well try to accomplish everything. :) > > I feel decently comfortable in the code as I spent last night getting a map > of the terrain. I have started a local git branch for performing these > changes. I'll file 2 JIRAs to cover this (change to logback, change > processing order). > > Felix, is this [1] the whiteboard sanbox you speak of? Exactly. But you might also use the Apache Review Board, if you like. > > Let me know if I sound crazy on any of this. All things said, except: Thanks a lot for taking this over ! Regards Felix > > > 1 http://svn.apache.org/repos/asf/sling/whiteboard/ > > > On Thu, Mar 3, 2011 at 8:56 AM, Justin Edelson > <jus...@justinedelson.com>wrote: > > > Go Carl!!! > > > > On Mar 3, 2011, at 2:58 AM, Felix Meschberger <fmesc...@adobe.com> wrote: > > > > > Hi Carl, > > > > > > Am Mittwoch, den 02.03.2011, 21:37 +0000 schrieb Carl Hall: > > >> Looks like I have bought some cycles to work on this. I am familiarizing > > >> myself with the code now. I'll plan to first replace the homegrown impl > > with > > >> logback. Any suggestions on direction or features are most welcomed. > > > > > > The most important point is, that existing configurations and > > > configuration mechanisms (factory configurations for writers and > > > loggers) must still be supported. > > > > > > Further points would then probably be extending the current > > > configuration mechanisms to support more logback features: > > > > > > - different Appenders > > > - Appender extension > > > > Definitely in favor of these two conceptually, but I would prefer we didn't > > expose the implementation detail that we're using logback. Possible? > > > > > - add Sling to the list of open-source projects using it > > > (see http://logback.qos.ch) > > > > > > I think this will be a major rework. How about starting this in a > > > whiteboard sandbox ? > > > > > > Regards > > > Felix > > > > > >> > > >> > > >> On Fri, Feb 18, 2011 at 10:09 AM, Felix Meschberger <fmesc...@adobe.com > > >wrote: > > >> > > >>> Hi, > > >>> > > >>> Am Donnerstag, den 17.02.2011, 08:58 +0000 schrieb Bertrand Delacretaz: > > >>>> Hi, > > >>>> > > >>>> On Wed, Feb 16, 2011 at 10:49 PM, Carl Hall <c...@hallwaytech.com> > > >>> wrote: > > >>>>> Is it possible to send the access log entries as OSGi events? I see > > the > > >>> use > > >>>>> of RequestLogger which doesn't have such capabilities. To send access > > >>> log > > >>>>> entries to as events, would a patch be required for SlingMainServlet > > et > > >>> al? > > >>>> > > >>>> In theory the LogReaderService might help for that, but the way our > > >>>> logging is implemented does not allow us to use it currently, see > > >>>> http://markmail.org/message/dlx5yvbjr74d46mh > > >>>> > > >>>> I think improving this would be useful, if someone has the cycles... > > >>> > > >>> As I already mentioned in the reference mail thread, using LogReader > > >>> does not work. I thought about reverting the LogService-SLF4J > > >>> interconnection in that SLF4J would log to LogService. But this turns > > >>> out to not be practical -- mostly because LogService does not allow the > > >>> same level of flexibility regarding log categories .... > > >>> > > >>> I really think the correct solution going forward (and needing cycles > > >>> here) would be to replace our home-grown SLF4J implementation with an > > >>> existing implementation (logback comes to mind) which would allows us > > >>> for better extensibility and reuse. > > >>> > > >>> Regards > > >>> Felix > > >>> > > >>> > > >>>> > > >>>> -Bertrand > > >>>> > > >>>> [1] > > >>> > > http://www.osgi.org/javadoc/r4v42/org/osgi/service/log/LogReaderService.html > > >>> > > >>> > > >>> > > > > > > > >
