Please take the @Override annotations out. @Override on interface methods 
requires Java 6.

Other than that, LGTM. Commit away!

Thanks,

Justin

On Mar 31, 2011, at 2:24 PM, Eric Norman <[email protected]> wrote:

> Hi All,
> 
> I found a use case where I could also use an upgrade to jackrabbit 2.2.5 to
> utilize some changes in user/group management.  I filed JIRA
> issue SLING-2044 for tracking and will attempt the upgrade today.
> 
> Regards,
> Eric
> 
> On Fri, Mar 25, 2011 at 8:23 AM, Justin Edelson 
> <[email protected]>wrote:
> 
>> On Fri, Mar 25, 2011 at 9:03 AM, Ian Boston <[email protected]> wrote:
>>> 
>>> On 25 Mar 2011, at 12:54, Justin Edelson wrote:
>>> 
>>>> 
>>>> 
>>>> On Mar 24, 2011, at 5:06 PM, Ian Boston <[email protected]> wrote:
>>>> 
>>>>> 
>>>>> On 24 Mar 2011, at 20:44, Craig Ganoe wrote:
>>>>> 
>>>>>> 
>>>>>> Is there any documentation for upgrading the jackrabbit version in the
>> Sling build?
>>>>> 
>>>>> AFAIK, there is not.
>>>>> Ian
>>>> 
>>>> There is, in a sense. Look at JIRA and Subversion and you'll see the
>> exact set of changes made for prior upgrades.
>>> 
>>> good point,
>>> 
>>> 
>> https://issues.apache.org/jira/browse/SLING-1660?page=com.atlassian.jira.plugin.ext.subversion%3Asubversion-commits-tabpanel#issue-tabs
>>> 
>>> http://svn.apache.org/viewvc?view=revision&revision=987559
>>> 
>>> was that the right issue ?
>> 
>> SLING-1531 too...
>> 
>>> 
>>> Ian
>>> 
>>> 
>>>> 
>>>> Justin
>>>>> 
>>>>>> 
>>>>>> Thanks.
>>>>>> 
>>>>>> Craig
>>>>>> 
>>>>> 
>>> 
>>> 
>> 

Reply via email to