Since the change was released, please create a new Jira. That way future software archaeologists can track which version has the degradation and which version has the fix.
On Mon, Feb 26, 2024 at 7:41 AM Justin Sweeney <justin.sweene...@gmail.com> wrote: > I can take another look at this. Changed the implementation for matching > glob patterns to avoid a third party dependency, but it seems like we may > just want to use the original implementation from Apache Commons to avoid > the performance degradation. Is the best practice here to do a PR with the > original Jira or create a new Jira? > > On Sat, Feb 24, 2024 at 10:54 AM Gus Heck <gus.h...@gmail.com> wrote: > > > Likely Introduced by SOLR-17022: Support for glob patterns for fields in > > Export handler, Stream handler and with SelectStream streaming expression > > (#1996) > > > > On Sat, Feb 24, 2024 at 10:51 AM Gus Heck <gus.h...@gmail.com> wrote: > > > > > Well... awesome that you have identified and documented this. Not > awesome > > > that it happened of course. Definitely Jira worthy. > > > > > > On Fri, Feb 23, 2024 at 9:55 PM Ishan Chattopadhyaya < > > > ichattopadhy...@gmail.com> wrote: > > > > > >> Awesome. Please feel free to open a JIRA issue about it. > > >> > > >> On Fri, 23 Feb, 2024, 5:03 pm Oleksandr Tkachuk, < > sasha547...@gmail.com > > > > > >> wrote: > > >> > > >> > We have ~170000 dynamic fields like abc_xxx, and requests like > > >> > /select?fl=abc_* took ~180ms with 9.4.1, but after upgrading to > 9.5.0 > > >> > such requests now take ~620ms to execute. > > >> > > > >> > It seems in 9.5.0 > > >> > org.apache.solr.common.util.GlobPatternUtil.matches > > >> > used instead of > > >> > org.apache.commons.io.FilenameUtils.wildcardMatch > > >> > Which leads to huge losses in performance. > > >> > > > >> > Here is the call tree from the profiler: > > >> > 9.4.1 > > >> > https://i.imgur.com/2gubfDr.png > > >> > > > >> > 9.5.0 > > >> > https://i.imgur.com/JIZ1E9u.png > > >> > > > >> > > > > > > > > > -- > > > http://www.needhamsoftware.com (work) > > > https://a.co/d/b2sZLD9 (my fantasy fiction book) > > > > > > > > > -- > > http://www.needhamsoftware.com (work) > > https://a.co/d/b2sZLD9 (my fantasy fiction book) > > >
