On 29/02/2008 2:05 PM, Theo Van Dinter wrote: > On Fri, Feb 29, 2008 at 07:11:05PM +0100, Matus UHLAR - fantomas wrote: >> I wonder if SPF rules shouldn't be considered network... they require DNS >> lookups, don't they? > > Yes, DNS is required.
Only if there aren't Received-SPF headers to reuse results from (in 3.2 or later). > What makes you think that SPF isn't considered a > network test though? Right in the code is: > > return unless $scanner->is_dns_available(); Which comes after the attempt to reuse the Received-SPF headers. > Also, the rules are listed as net rules: > > tflags SPF_FAIL net > [...] > tflags SPF_HELO_SOFTFAIL net In trunk they are again (jm's r596095). Before that they weren't, and still aren't in the 3.2 branch (my r588457). Now I'm not sure what to do. We need to generate scores for the rules for set0 (so they shouldn't have tflags net) but those scores probably aren't going to be very accurate since I don't think many of the mass-check contributors have Received-SPF headers in their mail. http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5842 Daryl
