Re: "svnlook pl --revprop" does not work on transactions?

[Alexey Neyman]

On Saturday 27 February 2010 11:35:24 am Lieven Govaerts wrote:
> > Note that it always uses svn_fs_revision_proplist(), even when '-t TXN'
> > is passed. In this case, c->rev_id == SVN_INVALID_REVNUM (-1), and
> > svn_fs_revision_proplist() rightfully fails.
> >
> > Shouldn't it be using svn_fs_txn_proplist() instead, just as
> > get_property() chooses between svn_fs_txn_prop() and
> > svn_fs_revision_prop()?
> 
> Think so. Do you want to submit a patch to fix this issue?

Sure, attached.

Alexey.

Index: subversion/svnlook/main.c
===================================================================
--- subversion/svnlook/main.c	(revision 917057)
+++ subversion/svnlook/main.c	(working copy)
@@ -1687,7 +1687,14 @@
     }
   else
     {
-      SVN_ERR(svn_fs_revision_proplist(&props, c->fs, c->rev_id, pool));
+      if (! c->is_revision)
+	{
+	  SVN_ERR(svn_fs_txn_proplist(&props, c->txn, pool));
+	}
+      else
+	{
+	  SVN_ERR(svn_fs_revision_proplist(&props, c->fs, c->rev_id, pool));
+	}
       revprop = TRUE;
     }