Daniel Shahaf wrote on Mon, 23 Mar 2020 05:45 +0000:
> 钱海远(Nathan) wrote on Mon, 23 Mar 2020 05:30 +0000:
> > The expected behaviour is: 'svnadmin dump' should include all properties.
> >
> > It happened in command : svnadmin dump --include .
> >
> > I organized the calling relationship of the function:
>
> I can't reproduce that:
>
> [[[
> % lldb -- svnadmin dump r --include=/foo
> ⋮
> (lldb) n
> Process 10902 stopped
> * thread #1, name = 'svnadmin', stop reason = step over
> frame #0: 0x00007ffff7d9ba71
> libsvn_repos-1.so.0`svn_repos_fs_revision_proplist(table_p=0x00007fffffffddf8,
> repos=0x00007ffff765b4c0, rev=0,
> authz_read_func=(libsvn_repos-1.so.0`dump_filter_authz_func at dump.c:1997),
> authz_read_baton=0x00007fffffffdf70, pool=0x00007ffff54b6028) at fs-wrap.c:514
> 511 authz_read_func,
> authz_read_baton,
> 512 pool));
> 513
> -> 514 if (readability == svn_repos_revision_access_none)
> 515 {
> 516 /* Return an empty hash. */
> 517 *table_p = apr_hash_make(pool);
> (lldb) p readability
> (svn_repos_revision_access_level_t) $1 = svn_repos_revision_access_full
> ]]]
>
> The value svn_repos_revision_access_full is correct, and indicates that
> the line you patched won't be executed.
>
It also indicates that all properties on the revision will be included
in the dumpfile.
However, note that nothing guarantees that svn:log exists for every
revision in the repository. You can check with «svnlook propget --revprop
-r N $REPOS_PATH svn:log».
Note that «svnlook log» does NOT error on revisions that don't have
svn:log set. (This seems to be a bug.)
