On Wed, Nov 03, 2021 at 05:21:19PM +0100, Thomas Weißschuh wrote:
> On 2021-11-03 17:14+0100, Stefan Sperling wrote:
> > On Wed, Nov 03, 2021 at 04:47:39PM +0100, Thomas Weißschuh wrote:
> > > The svn_atomic__init_once() inside svn_repos_authz_initialize() seems to 
> > > work
> > > correctly. synchronized_authz_initialize() is only executed once.
> > > 
> > > I am arguing that it should *not* be executed only once because the pools 
> > > that
> > > it gets called with the first time will be invalid when it is called the 
> > > second
> > > time. So it should rebuild authz_pool with the new parent pool.
> > > 
> > > Replacing the call through svn_atomic__init_once() with an unconditional 
> > > call
> > > makes the issue go away.
> > 
> > I see. So for some reason, under httpd's control, the SVN module's
> > post_config hook is invoked several times, each time with a different
> > pool? Do we know why this is happening?
> 
> I'll investigate that a bit more.
> 
> > If this is valid httpd behaviour then the code in authz.c is making
> > an invalid assumption. And there could similar problems elsewhere,
> > in svn_fs_initialize() for example.
> 
> Should we keep this discussion on the ML or should I open a ticket for it?

Both :)

I agree that this warrants a new ticket. Once the problem is fully
understood we can still decide to close this ticket in case the real
issue turns out to be somewhere else. Please feel free to create a
new ticket for this in our tracker. Thanks!

Reply via email to