On Thu, Dec 7, 2023 at 12:28 PM Jason Yundt <jason@jasonyundt.email> wrote: > > On Thu, Dec 07, 2023 at 04:12:00PM +0100, Daniel Sahlberg wrote: > > Den tors 7 dec. 2023 kl 15:43 skrev Jason Yundt <jason@jasonyundt.email>: > > > > > Here’s the questions that I still have: > > > > > > • With Git, there’s multiple different ways of sending your changes > > > upstream (pull requests, git-request-pull and git-send-email). Are there > > > multiple ways of doing it with Subversion or do you always just send > > > emails with patches attached? > > > > > > > Unfortunately there are no equivalents of Github that offer the "pull > > requests" functionality for Subversion as far as I know. The normal > > process, at least within the ASF, is to create a patch and either attach it > > as a file (more below) or directly within the e-mail itself. > > > > The other solution would be to commit directly to the actual repository but > > then you need write access (it IS possible to say "Jason has rw access to > > /jasons-branches/ and r access to everything else except /private where he > > has no access" if one would like to create a "staging area", then you could > > create your own branch and request merges from that one, but the process > > would be much less intuitive than the Github pull request process). > > > > Subversion has the ability to do merges from foreign repositories [2] so in > > theory it would be possible to create your own repository, commit your > > patches and ask the remote party to merge these commits, but it is also not > > very intuitive. > > > > > > > > > > • I followed my own instructions to create an example patch for > > > <https://svn.apache.org/repos/asf/subversion/trunk/>, and I attached it > > > to this email. Does it look like I created the patch correctly? > > > > > > > I would prefer to not have the log message in the patch file and instead > > add it in the e-mail. That way it would be much easier to apply the patch, > > otherwise you need to edit the file before applying it. The triple brackets > > are used in an e-mail to indicate something verbatim in a mail, such as: > > > > Suggested log message: > > [[[ > > * README: > > Add some nonsense as an example > > ]]] > > > > It could also be used to add the patch directly in the e-mail. > > > > Kind regards, > > Daniel > > > > > > > [1]: < > > > https://subversion.apache.org/docs/community-guide/general.html#patches> > > > > > > > > > [2]: > > https://svnbook.red-bean.com/nightly/en/svn.branchmerge.advanced.html#svn.branchmerge.nomergedata > > That was really helpful. Thank you!
I would also ask the project you are contributing to how they like to receive contributions. Maybe they have it documented. If they receive patches via mailing list like Apache projects do, then maybe you can see that list for examples of other contributions and what they look like. The Subversion project had a commit message style the committers care about so I always would review recent contributions as a reminder ... of course you can also see those by running svn log to get a sense of what commit message style is in the project. Mark
