Thanks Chris, I've created a pull request on github: https://github.com/apache/tomcat85/pull/3
> and then look at the diffs manually It's an almost complete rewrite and has very little in common with the old encoder Svetlin 2016-08-30 20:56 GMT+03:00 Christopher Schultz <ch...@christopherschultz.net >: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Svetlin, > > On 8/28/16 12:57 PM, Svetlin Zarev wrote: > > Hi, > > > > Today I had some free time, so I implemented a more (memory and > > performance wise) efficient URLEncoder [1] and I'd like to > > contribute it if there is interest for improvement in that area. My > > encoder has close to zero allocation rate (unless there is very > > high concurrency for the encode() operations, but still will be > > much more memory efficient than the current encoder) and encodes > > 2-4 times faster than the current implementation. It is available @ > > [1]. I'm open for reviews, critiques, questions, suggestions, etc. > > > > [1] https://github.com/SvetlinZarev/UrlEncoder > > Can you post this as a pull request, patch, or similar? Nobody really > wants to download this code, replace their own local code, and then > look at the diffs manually. I suspect that's why nobody has looked at > it, yet. > > - -chris > -----BEGIN PGP SIGNATURE----- > Comment: GPGTools - http://gpgtools.org > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQIcBAEBCAAGBQJXxcjVAAoJEBzwKT+lPKRYsCMQAKy/pVLDeSWvcbbHMYwOLwa5 > xhBc3R0ev51qt9rMbkBTQhOZM/beM5u9AcOevFNaQlqr6knxui0R2v7fcM7LKxzU > w8iRxe+8w1GxA/nPVmUAXU5geL7Z7gnyIf+GBhOlxn8R4cXfkvRBCOP0shZpIXPr > fF4buxBLGOii3ApiYELdxxM6andEXc8SHd+CoCm9fc3GPMVyR4eFDEg7nNc1Y44t > FWRBOXNCf0nJRHUDswEqK2ZTlTvd1GFTInLAy9m30uJRzkGDa3ytgfikaBE/c/Je > ctCtz/g9xUk715YFhm23ZAmGvzi3bWBj9PZ3yTixf646Oa8WPsWWm7vALjRNZcfG > j8Cy0ugEo1kT9wr1anIdPtr4q22E3k4Gu8SAhEObcO65dFtdZ2kvQ+tJxTceOmjn > vyplST7kVORuhtWf+rj+L+VgHZsRR54+5C8a9Hf1/TSaI1ztWJbFIYuJr+YgnGw5 > Z264C/rWPr4fd1BRNCwJz9iHoC24IuTJAiNNcVQHrs7xKn16sW4Sq/hM5AE7oJ/5 > RhvpLtZPQmxpqVjvxPallYT0/lMN3CJ26m7A5rf0242MMf9zIsxsnnNUznhh2zNR > gyJsTHJZ2o4tuwEclimzxrwIbO5RxgIeoTdxTbhsE4775oSQ3VHvE07yDPLlqRAh > My3/WOXu8myi0WeLoRzE > =5SJi > -----END PGP SIGNATURE----- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > >
