On 12/10/2020 18:48, Christopher Schultz wrote: <snip/>
> There is already a check for -1 for the last-modified time for the file > in the ZIP archive. Also for 0 for some reason (sorry, Brian Kernighan, > you can't store your first file in a ZIP file!). I've tracked that change back to this: https://bz.apache.org/bugzilla/show_bug.cgi?id=33636 I don't see why "0" is not allowed (but neither do I see not allowing it being a significant problem). > I think that any negative value should be ignored, so the expanded-file > on the disk should get "now" as its last-updated time. So just change > the comparison to: > > if(lastModified > 0) { > expandedFile.setLastModified(lastModified); > } Hmm. I do wonder about silently swallowing what is almost certainly some some of build system error (and breaking caching as per BZ 33636) when lastModified is negative. Ignoring files that return -1 (not specified) seems reasonable. I think an exception is better than silently swallowing here. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
