Tim,
Thanks for looking at this.
On 25/06/2025 13:55, Tim Funk wrote:
This is a good cleanup. I one question for confirmation, let's say
we have this config:
<welcome-file>index.html</welcome-file>
<welcome-servlet>index.do</welcome-servlet>
<welcome-file>index.htm</welcome-file>
With
-- request = /foo/
-- AND file exists of = /foo/index.htm
Since index.htm exists, we'd process as /foo/index.htm despite it being
"3rd" in the welcome file list since welcome-file's are processed first.
Is the above interpretation correct?
No. Assuming there was a servlet mapped to *.do, the request would be
processed as /foo/index.do
Use case where the above might occur: web.xml has
<welcome-file>index.html</welcome-file>
<welcome-servlet>index.do</welcome-servlet>
Then there is an included fragment <welcome-file>index.htm</welcome-file>
So that we have a welcome-file after a welcome servlet in the final config.
I think I need to look at the rules for merging welcome resources. That
might prompt some changes to the PR.
Mark
-Tim
On Wed, Jun 25, 2025 at 3:19 AM Mark Thomas <ma...@apache.org> wrote:
All,
Servlet 6.2 intends to address a long standing (more than 10 years)
issue with welcome files. Consider the following:
PR: https://github.com/jakartaee/servlet/pull/881
Issue: https://github.com/jakartaee/servlet/issues/20
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org
