-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 André,
André Warnier wrote: > Would what Markus wants to do not be easier to do with a servlet filter ? > It would also be a per-application thing, rather than a > one-size-fits-all, no ? Markus was looking at using the ExtendedLogAccessValve which does everything he wants except to include the POST body in the logging. I was suggesting that he augment the Valve to include that capability, as someone else might want to do the same thing. (I always look for opportunities for TC users to improve TC whenever possible). Yes, a Filter could have been used. Valves are basically TC-specific Filters that operate at a slightly lower level: they fill the same type of niche, but have access to TC-specific classes instead of just the servlet API stuff (for instance, you can get to TC's "Request" instead of just what's available through HttpServletRequest). Since the existing implementation was a Valve, I would recommend that he modify it instead of "porting" it to a Filter. Valves can be applied to specific applications in context.xml, so it's not necessary to apply a Valve to all applications. Honestly, an app-server-agnostic Filter that performs the same function would be a really useful thing to write. Care to try your hand at writing it? ;) Hope that helps, - -chris -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkkbJ/oACgkQ9CaO5/Lv0PBUkQCfee0pLFhlmbqdwJ08RT5i/JMB RxMAn3fMI+tNW9xaUuV2SxtO7x+RtTnd =FGZy -----END PGP SIGNATURE----- --------------------------------------------------------------------- To start a new topic, e-mail: users@tomcat.apache.org To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
