-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Konstantin,
On 10/3/2011 4:16 PM, Konstantin Kolinko wrote: > 2011/10/3 Christopher Schultz <ch...@christopherschultz.net>: >> On 9/30/2011 2:18 PM, Konstantin Kolinko wrote: >>> 2011/9/30 Christopher Schultz <ch...@christopherschultz.net>: >>>> The OP should be able to put the Filter into the <Context> >>>> in such a way that the Filter wraps the AccessLogValve, no? >>>> >>> >>> 1. You cannot put a Filter into Context. >> >> Mmm. Why do I always think that you can do this sort of thing? >> Maybe I'll log an enhancement that allows us to do this: it seems >> reasonable to allow Filters to be interspersed with Valves, >> especially for things like this. > > This: https://issues.apache.org/bugzilla/show_bug.cgi?id=51754 > worries me a bit more. Allowing <Valve> and <Filter> to be arbitrarily ordered shouldn't affect that bug, which has to do with where the default filters are inserted into the valve/filter chain. That problem would still exist and, IMO, not get any worse by allowing <Filter> to appear anywhere a <Valve> can appear. >>> 3. A Valve can modify a Request, while Filter cannot. >> >> Both Filter and Valve can wrap the request, which can be seen as >> "modifying" it, though it's not really modifying it. > > Valve has access to o.a.c.connector.Request object, which is > modifiable. Right: it is directly modifiable instead of... maskable :) - -chris -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6LLFEACgkQ9CaO5/Lv0PBvsACeNB77v1spBBGq3M+q+Gm9S8RM QRMAniS6odp+lVkhTcTMz5sYFvtET63h =2H7h -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
