No problem, just glad I was finally able to find the critter today since it
had just happened at the same time I did some major refactoring of how I do
modals in my project. I blamed my code for the first part of the day...
then I found out it was you. <snicker>
Thanks... I will watch for an update.
Matej Knopp-2 wrote:
>
> Shoot. Sorry, that was indeed my fault. Will fix ASAP.
>
> -Matej
>
> On 9/27/07, donhass <[EMAIL PROTECTED]> wrote:
>>
>> I had the same problem today after getting an updated snapshot from
>> today.
>> None of my Modal Windows that had panel with Forms on them would close
>> any
>> longer.
>>
>> My investigation found that the update to wicket-ajax.js is the culprit.
>> Revision 579593 to be specific.
>>
>> /jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js
>> (revision 579593)
>>
>> It appears the update on Sept 26 at 7:16 this morning by knopp broke this
>> for me. Since if I get the previous revision (579172) the problem goes
>> away.
>>
>> Specific code in question is listed below. Hope this helps save someone
>> else some headaches this caused for me this morning. I guess that is
>> what I
>> get for using latest snapshots some times. :)
>>
>> Wicket still the best!
>>
>> @@ -1116,15 +1116,34 @@
>> if (encoding != null) {
>> text = Wicket.decode(encoding, text);
>> }
>> - try {
>> - // do the evaluation
>> - eval(text);
>> - } catch (exception) {
>> - Wicket.Log.error("Exception evaluating
>> javascript: " + exception);
>> - }
>> - // continue to next step
>> - notify();
>> - });
>> +
>> + // test if the javascript is in form of
>> identifier|code
>> + // if it is, we allow for letting the javascript
>> decide when the rest
>> of processing will continue
>> + // by invoking identifier();
>> + var res =
>> text.match("([a-z|A-Z_][a-z|A-Z|0-9_]*)\\|(.*)");
>> +
>> + if (res != null) {
>> + text = "var f = function(" + res[1] + ") {" +
>> res[2] +"};";
>> + try {
>> + // do the evaluation
>> + eval(text);
>> + f(notify);
>> + } catch (exception) {
>> + Wicket.Log.error("Exception evaluating
>> javascript: " + exception);
>> + }
>> +
>> + } else {
>> + // just evaluate the javascript
>> + try {
>> + // do the evaluation
>> + eval(text);
>> + } catch (exception) {
>> + Wicket.Log.error("Exception evaluating
>> javascript: " + exception);
>> + }
>> + // continue to next step
>> + notify();
>> + }
>> + });
>> },
>>
>> // Adds a closure that processes a header contribution
>>
>>
>>
>>
>> Russell Morrisey wrote:
>> >
>> > Wicket-1.3.0-SNAPSHOT
>> > When I call ModalWindow#close() using an ajax button in my modal
>> window's
>> > page, I'm getting an error in the AJAX debug, and the window doesn't
>> > close. It looks like someone else has already encountered this issue:
>> >
>> > https://issues.apache.org/jira/browse/WICKET-1003
>> >
>> > I posted a quickstart with instructions & error message output on the
>> > JIRA.
>> > Hope this helps,
>> >
>> > Russell Morrisey
>> >
>> > Computer Sciences Corporation
>> > Registered Office: 2100 East Grand Avenue, El Segundo California 90245,
>> > USA
>> > Registered in USA No: C-489-59
>> >
>> >
>> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>> > NOTE: Regardless of content, this e-mail shall not operate to bind CSC
>> to
>> > any order or other contract unless pursuant to explicit written
>> agreement
>> > or government initiative expressly permitting the use of e-mail for
>> such
>> > purpose.
>> >
>> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>> >
>> >
>>
>> --
>> View this message in context:
>> http://www.nabble.com/ModalWindow-JS-error-tf4524801.html#a12910649
>> Sent from the Wicket - User mailing list archive at Nabble.com.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
>
--
View this message in context:
http://www.nabble.com/ModalWindow-JS-error-tf4524801.html#a12911207
Sent from the Wicket - User mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
