guess so -igor
On 10/1/07, Dan Syrstad <[EMAIL PROTECTED]> wrote: > > So the contract of the method has changed since 1.2.6? > -Dan > > On 10/1/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > > > i think the way it works now is that there is a visitor that goes > through > > the hierarchy and calls detach() on every component. so there is no need > > for > > detachmodels to do much more then detach the models for the current > > component only. > > > > -igor > > > > > > On 10/1/07, Dan Syrstad <[EMAIL PROTECTED]> wrote: > > > > > > Anyone know why Page.detachModels() no longer detaches the models of > all > > > child components in 1.3beta3? There is a bunch of code commented out > in > > > Page.detachModels() that previously did this. Now it just calls > > > super.detachModels() (on Component) which apparently just detaches the > > > model > > > immediately attached to the Page (which renders the need for > > > Page.detachModels() moot). I searched the lists and the closest thing > I > > > found was a reference to > > https://issues.apache.org/jira/browse/WICKET-418, > > > but that seems to have to do with Ajax requests. > > > > > > This has broken a JUnit test that was testing a detachable model using > > > WicketTester. The same test passes in Wicket 1.2.6. Is there something > > > different I should be doing in 1.3? > > > > > > -Dan > > > > > >
