Well, as kind of our policy we make a lot of things final. But we do
remove the final if someone has a good reason for it. :)

Could you please create a jira issue with the finals you need to have removed?

Thanks.

-Matej

On 10/10/07, John Patterson <[EMAIL PROTECTED]> wrote:
> Also, there is special case code in WebRequestCodingStrategy for a
> mount with a null path.  This looks like a default mount  and is what
> I want to use.  But there is no way to add a mount with a null path
> as it is checked for.
>
> This class is so close to being extendable but not quite there.
>
>
> On 9 Oct 2007, at 16:01, Matej Knopp wrote:
>
> > Thinking about it, probably better (and more solid) approach would be
> > for you to copy the entire class (unless it references some package
> > protected classes).
> >
> > -Matej
> >
> > On 10/9/07, John Patterson <[EMAIL PROTECTED]> wrote:
> >> Just a bit more info on the problem... encoding allows me to override
> >> the equivalent method:
> >>
> >> rg.apache.wicket.IRequestTarget)
> >>          */
> >>         public final CharSequence pathForTarget(IRequestTarget
> >> requestTarget)
> >>         {
> >>                 // first check whether the target was mounted
> >>                 IRequestTargetUrlCodingStrategy encoder =
> >> getMountEncoder
> >> (requestTarget);
> >>
> >>
> >> ... here getMountEncoder() is not final.
> >>
> >> Cheers,
> >>
> >> John
> >>
> >>
> >> On 9 Oct 2007, at 15:37, John Patterson wrote:
> >>
> >>> Hi,
> >>>
> >>> I seem to be making progress with my custom URL scheme but have hit
> >>> a small wall.  I have subclassed WebRequestCodingStrategy because I
> >>> want to keep the mountable page behaviour but just enhance it to
> >>> return my own target if no mounts are found and default processing
> >>> does not apply.  I am trying to implement
> >>>
> >>> IRequestTarget targetForRequest(RequestParameters)
> >>>
> >>> ... but I cannot find a way to return my own target.  Everything is
> >>> final or private.  If this method
> >>>
> >>>       public final IRequestTargetUrlCodingStrategy
> >>> urlCodingStrategyForPath(String path)
> >>>
> >>> was not final I could return my implementation.  Or if I could add
> >>> a mount which returned null for getMountPath() then I would be
> >>> sweet.
> >>>
> >>> Cheers,
> >>>
> >>> John
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to