FeedbackPanel#newMessageDisplayComponent throws NullPointerException if empty message is inserted

[Edvin Syse]

Hi,

I sometimes do:
try {
        // work
} catch (Exception e) {
        error(e.getMessage());
}

and came across an Exception that didn't have a message, and was greeted with a NullPointerException from the FeedbackPanel. Ofcourse this 
was my mistake but maybe the code could be changed like this:

protected Component newMessageDisplayComponent(String id, FeedbackMessage 
message) {
        Label label = new Label(id, message.getMessage().toString()); // Current
        Label label = new Label(id, message.getMessage() != null ? 
message.getMessage().toString() : getString("emptyMessage")); // New
        label.setEscapeModelStrings(FeedbackPanel.this.getEscapeModelStrings());
        return label;
}

.. and then add emptyMessage or some key to FeedbackPanel.properties or is this 
a bad idea?


-- Edvin

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]