Johan, The fix looks good. I no longer get warnings under Glassfish.
Thank you, Gili cowwoc wrote: > > According to > http://java.sun.com/j2ee/sdk_1.3/techdocs/api/javax/servlet/ServletRequest.html#setCharacterEncoding(java.lang.String): > > "This method must be called prior to reading request parameters or reading > input using getReader()." > > My interpretation is that requesting the context path is okay, so long as > you do not request the query parameters. I'll test your commit to be sure. > > Gili > > > Johan Compagner wrote: >> >> is only getParameters() a problem? >> or cant we also ask for the context path/url? >> >> see my commit i just did it should fix your problem if it is only the >> getParameters of the getLastModified wat is a problem >> >> >> johan >> >> >> On Wed, Sep 24, 2008 at 6:53 AM, cowwoc <[EMAIL PROTECTED]> wrote: >> >>> >>> Hi, >>> >>> I spent a few hours tracking down the cause of >>> https://issues.apache.org/jira/browse/WICKET-1816 but now I need someone >>> from the Wicket team to help me fix it. >>> >>> Can someone please fix the lines of code I mention in the report and >>> then >>> send me back a patched version for testing? >>> >>> To be clear: this bug affects *all* platforms. Tomcat fails silently, >>> which >>> is even worse. >>> >>> Gili >>> -- >>> View this message in context: >>> http://www.nabble.com/Need-help-fixing-bug--1816-tp19641982p19641982.html >>> Sent from the Wicket - User mailing list archive at Nabble.com. >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>> For additional commands, e-mail: [EMAIL PROTECTED] >>> >>> >> >> > > -- View this message in context: http://www.nabble.com/Need-help-fixing-bug--1816-tp19641982p19651029.html Sent from the Wicket - User mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
