both 1899 and 982 are pretty friggin vague :) how often are link titles dynamic? i am thinking not very often at all, so why add another imodel slot to make the component event bigger for a small percantage of usecases.
in most cases <a wicket:id="external-link" title="" wicket:message="title:key-to-title">..</a> works just fine for internationalization. for the very few times where you do need a dynamic title you can use an attribute appender or subclass externallink and write a trivial implementation. we try to keep the core components with as small a footprint as possible, but we also make them pretty damn trivial to extend. -igor On Tue, Oct 28, 2008 at 9:15 AM, Steve Swinsburg <[EMAIL PROTECTED]> wrote: > Well the last post was unclear about which patch he was referring to > (Javadoc or codebase). > > From the previous discussions, it's clear that a patch for a new constructor > won't be considered. I will, however, get some information to extend the > Javadocs and submit that. > Javadco improvement Jira here: > https://issues.apache.org/jira/browse/WICKET-1899 > > Interestingly enough, a ticket was created last year to get the ball rolling > with accessibility: > https://issues.apache.org/jira/browse/WICKET-982 > > Steve > > > On 28 Oct 2008, at 16:06, James Carman wrote: > >> I don't think Martijn is intentionally being vague. DDC is a common >> abbreviation for DropDownChoice among folks within the Wicket >> community. As for the request for a patch, that's the best way to >> get your code suggestions merged into the codebase, providing a patch. >> Please make sure you include test cases with your patch that exercise >> the new code. >> >> On Tue, Oct 28, 2008 at 12:02 PM, Steve Swinsburg >> <[EMAIL PROTECTED]> wrote: >>> >>> For the Javadoc? (please stop being so vague!) >>> >>> No worries, I'll do this up and submit it into a general accessibility >>> Javadoc improvement Jira ticket. >>> >>> Steve >>> >>> >>> >>> >>> >>> >>> On 28 Oct 2008, at 15:57, Martijn Dashorst wrote: >>> >>>> On Tue, Oct 28, 2008 at 4:48 PM, Steve Swinsburg >>>> <[EMAIL PROTECTED]> wrote: >>>>> >>>>> So my vision for wanting to enforce a bit of accessibility on the web >>>>> is >>>>> narrow(?), but no one wants to move forward with the most simple of >>>>> modifications to make it easier to implement accessibility. The most >>>>> basic >>>>> of things to do would be to update the JavaDocs for the API to say: >>>>> >>>>> "NOTE: you should always include an AttributeModifier/Appender (or roll >>>>> your >>>>> own implementation) to include the title attribute on every link. >>>>> here's >>>>> some examples, etc" >>>> >>>> Where's your patch then? >>>> >>>> Martijn >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>>> For additional commands, e-mail: [EMAIL PROTECTED] >>>> >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
