well, that's for the first reason.

Doing this would allow us to distinguish wicket Ids from keys. So it would
be really better for our translators since we could concentrate our keys in
a couple of files, and prefixing our keys (or even rename them totally)
could add sense to them. Currently those are linked to the wicketId which is
not always well named (even more if we use it in a reusable component). 



igor.vaynberg wrote:
> 
> sorry, i dont really understand...
> 
> you want to change the name of the keys because you do not like the
> "null" and "nullValid" terms?
> 
> or do you want to change them globally? in which case you can have the
> "null" and "nullValid" keys defined in your MyApplication.properties.
> 
> -igor
> 
> On Fri, Oct 16, 2009 at 5:30 AM, Guillaume Mary
> <[email protected]> wrote:
>> Hi all,
>>
>> The DropDownChoice and overall AbstractSingleSelectChoice does not allow
>> to specify the internationalization key for null nor nullValid values.
>> Instead it laies down the management of those keys with getId() +
>> ".null".
>>
>> I suggest a very small enhancement to externalize the building of these
>> keys in 2 protected methods getNullKey() and getNullValidKey() (the names
>> don't really matter) and call them in the
>> AbstractSingleSelectChoice.getDefaultChoice(Object) method.
>>
>> It won't disturb the actual running and allows developper to organize
>> their keys as they like in order to help translators know what keys are
>> about (with prefix for example). For now this is not possible, or we have
>> to change component ids ...
>>
>>
>> Here are the 2 methods :
>> protected String getNullValidKey() {
>>                               return getId() + ".nullValid";
>>                }
>>
>>                protected String getNullKey() {
>>                               return getId() + ".null";
>>                }
>>
>>
>> If ok, I can create a JIRA enhancement with the full patch.
>>
>> Thanks
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
> 
> 
> 

-- 
View this message in context: 
http://www.nabble.com/DropDownChoice-and-null-value-internationalization-key-tp25924643p25949202.html
Sent from the Wicket - User mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to