Just took a quick look and it seems that our problem should still be solved. As a recap - were running into a problem with the URLConnection.getLastModfiedTime(), which under the hood opens a connection to a jar file using the JARURLConnection whose close() method is hidden. Combine this with the fact that in the URLResourceStream constructor the getLastModifiedTime() method was being called and you ended up with a lot of open FileURLConnections that couldn't be closed. The remedy still appears to be present in org.apache.wicket.util.io.Connections.getLastModified(URL url). As long as that method is called instead of directly calling getLastModifiedTime() on a URLConnection there should be no leak. I will run some more tests and if I find a problem I'll just open an issue.
The original issue is well documented http://www.mail-archive.com/[email protected]/msg20951.html here Adam igor.vaynberg wrote: > > we had to revert a part of that patch in 1.4.5 to fix a resource > streaming problem. please check with that. > > -igor > > On Wed, Dec 30, 2009 at 8:02 AM, adamatmagpie <[email protected]> wrote: >> >> I was able to track down the source of our problem and I did create a >> https://issues.apache.org/jira/browse/WICKET-2534 JIRA issue which was >> patched in Wicket 1.4.4. It boiled down to a resource leak in the >> URLResourceStream which is used by wicket to get access to the >> lastModifiedTime of jar files it is monitoring. The JIRA issue has some >> more >> detail, but I have tested the fix in 1.4.4 and it cleared up our issue >> straight away. >> >> Adam >> >> >> Ilja Pavkovic-3 wrote: >>> >>> >>> https://issues.apache.org/jira/browse/WICKET-2534 >>> >>> Am Mittwoch, 30. Dezember 2009 04:29:00 schrieb Doug Leeper: >>>> Was a JIRA ticket ever created for this? I couldn't find any thing >>>> related >>>> to it. >>>> >>>> Is any one else seeing this issue? I just ran across it in our dev env >>>> after redeploying my web app. >>>> >>>> Not sure if this wicket, jdk, or weblogic. >>>> >>>> Weblogic 10 >>>> JRockit (BEA JRockit(R) (build >>>> R27.6.5-32_o-121899-1.6.0_14-20091001-2113-linux-ia32, compiled mode)) >>>> Linux >>>> Wicket 1.4.4 >>>> >>> >>> -- >>> binaere bauten gmbh · tempelhofer ufer 1a · 10961 berlin >>> >>> +49 · 171 · 9342 465 >>> >>> Handelsregister: HRB 115854 - Amtsgericht Charlottenburg >>> Geschäftsführer: Dipl.-Inform. Ilja Pavkovic, Dipl.-Inform. Jost Becker >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >>> >> >> -- >> View this message in context: >> http://old.nabble.com/Too-Many-Files-Wicket-1.4.1-tp25983047p26968948.html >> Sent from the Wicket - User mailing list archive at Nabble.com. >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > > -- View this message in context: http://old.nabble.com/Too-Many-Files-Wicket-1.4.1-tp25983047p26970086.html Sent from the Wicket - User mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
