Hi! > 1. What are the implications of stripping jsessionid for all users...like > so in app object... > CharSequence encodedUrl = super.encodeURL(url); > return Strings.stripJSessionId(encodedUrl);
As a side effect you will disable session for cookieless connections. > 2. What does super.encodeURL(url); do and could the Wicket SEO wiki > example > https://cwiki.apache.org/WICKET/seo-search-engine-optimization.html > be modified to use... > > CharSequence encodedUrl = super.encodeURL(url); > return isAgent(agent) ? Strings.stripJSessionId(encodedUrl) : encodedUrl; Depends what you want to strip/not-strip... skipping encoding also strips but I am not sure if there is any other encoding happening... ** Martin > > > > > > Martin Makundi <martin.maku...@koodaripalvelut.com> > 08/06/2010 11:32 AM > Please respond to > users@wicket.apache.org > > > To > users@wicket.apache.org > cc > > Subject > Re: Wicket adds jsessionid to redirect onto external page > > > > > > > Hi! > >> And the Wicket SEO wiki provides a way to remove the JSessionId... >> https://cwiki.apache.org/WICKET/seo-search-engine-optimization.html > > This particular code does not work for first browser hit. > >> I understand why you would want to remove the jsessionid for bots, would >> it be "safe" to remove the jsessionid for all users to pretty up the > urls? > > I am stripping the jsessionid from remote redirects, because a > redirect like mywebiste -> otherwebsite;jsessionid results in a crash > on the otherwebsite. > > Anyways.. this turned out to be jetty bug as described before. > > > ** > Martin > >> >> >> >> Martin Makundi <martin.maku...@koodaripalvelut.com> >> 08/04/2010 02:21 PM >> Please respond to >> users@wicket.apache.org >> >> >> To >> users@wicket.apache.org >> cc >> >> Subject >> Re: Wicket adds jsessionid to redirect onto external page >> >> >> >> >> >> >> Cool ;) >> >> 2010/8/4 Don Ferguson <don.fergu...@gmail.com>: >>> Right, it's really a jetty bug, and looks like it was fixed recently: >>> >>> http://dev.eclipse.org/mhonarc/lists/jetty-commit/msg01598.html >>> >>> >>> On Aug 4, 2010, at 10:46 AM, Igor Vaynberg wrote: >>> >>>> afair the servlet spec says all urls have to be passed through that >>>> method and thats what we do. if its not working the problem is with >>>> the servlet container. >>>> >>>> -igor >>>> >>>> On Wed, Aug 4, 2010 at 10:39 AM, Martin Makundi >>>> <martin.maku...@koodaripalvelut.com> wrote: >>>>> Like a sledgehammer ;) >>>>> >>>>> But yes, so it's a bug in wicket "framework design". >>>>> >>>>> ** >>>>> Martin >>>>> >>>>> 2010/8/4 Don Ferguson <don.fergu...@gmail.com>: >>>>>> Ah, much better than my approach. >>>>>> >>>>>> On Aug 4, 2010, at 8:25 AM, Martin Makundi wrote: >>>>>> >>>>>>> Hi! >>>>>>> >>>>>>> I worked around like this: >>>>>>> >>>>>>> ((org.mortbay.jetty.Request) ((WebRequest) >>>>>>> >> > RequestCycle.get().getRequest()).getHttpServletRequest()).setSessionManager(null); >>>>>>> >>>>>>> >>>>>>> ** >>>>>>> Martin >>>>>>> >>>>>>> 2010/8/4 Don Ferguson <don.fergu...@gmail.com>: >>>>>>>> Hi Martin, >>>>>>>> Yes, I've encountered this. I think it's a bug in WebResponse. >> The culprit >>>>>>>> is the line: >>>>>>>> url = httpServletResponse.encodeRedirectURL(url); >>>>>>>> The url should only be encoded when redirecting to the originating >> site, but >>>>>>>> the code doesn't check. >>>>>>>> One workaround (short of fixing the bug) is to duplicate the >> functionality >>>>>>>> of WebResponse, commenting out the offending line. Then use it as >> such: >>>>>>>> getRequestCycle().setResponse(new >> NonEncodingWebResponse((WebResponse) >>>>>>>> getRequestCycle().getResponse())); >>>>>>>> getRequestCycle().setRequestTarget(new >>>>>>>> RedirectRequestTarget(url)); >>>>>>>> The source code is attached. >>>>>>>> >>>>>>>> >>>>>>>> -Don >>>>>>>> On Aug 4, 2010, at 2:22 AM, Martin Makundi wrote: >>>>>>>> >>>>>>>> Hi! >>>>>>>> >>>>>>>> I am doing something wrong? I am using: >>>>>>>> >>>>>>>> >> getResponse().redirect(getParameterFromRequest(RETURN_PAGE)); >>>>>>>> >>>>>>>> But the URL contains jsessionid. I think this is wrong because the >>>>>>>> target server does not understand the jsessiond and it returns 404 >>>>>>>> page not found. >>>>>>>> >>>>>>>> ** >>>>>>>> Martin >>>>>>>> >>>>>>>> >> --------------------------------------------------------------------- >>>>>>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>>>>>>> For additional commands, e-mail: users-h...@wicket.apache.org >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >> --------------------------------------------------------------------- >>>>>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>>>>>> For additional commands, e-mail: users-h...@wicket.apache.org >>>>>>> >>>>>> >>>>>> >>>>>> > --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>>>>> For additional commands, e-mail: users-h...@wicket.apache.org >>>>>> >>>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>>>> For additional commands, e-mail: users-h...@wicket.apache.org >>>>> >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>>> For additional commands, e-mail: users-h...@wicket.apache.org >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>> For additional commands, e-mail: users-h...@wicket.apache.org >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> For additional commands, e-mail: users-h...@wicket.apache.org >> >> >> >> >> >> >> Notice: This communication, including any attachments, is intended > solely >> for the use of the individual or entity to which it is addressed. This >> communication may contain information that is protected from disclosure >> under State and/or Federal law. Please notify the sender immediately if >> you have received this communication in error and delete this email from >> your system. If you are not the intended recipient, you are requested > not >> to disclose, copy, distribute or take any action in reliance on the >> contents of this information. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > > > > > > Notice: This communication, including any attachments, is intended solely > for the use of the individual or entity to which it is addressed. This > communication may contain information that is protected from disclosure > under State and/or Federal law. Please notify the sender immediately if > you have received this communication in error and delete this email from > your system. If you are not the intended recipient, you are requested not > to disclose, copy, distribute or take any action in reliance on the > contents of this information. --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
