Shouldn't this be on the dev mailing list instead? -----Original Message----- From: richard emberson [mailto:richard.ember...@gmail.com] Sent: Monday, October 18, 2010 8:50 PM To: users@wicket.apache.org Subject: code review: org.apache.wicket.pageStore.AsynchronousDataStore.removeData
org.apache.wicket.pageStore.AsynchronousDataStore.removeData A little code review please: In org.apache.wicket.pageStore.AsynchronousDataStore public void removeData(final String sessionId, final int id) { synchronized (WRITE_LOCK) { String key = getKey(sessionId, id); if (key != null) { entryMap.remove(key); } Entry entry = entryMap.get(key); if (entry != null) { entries.remove(entry); } } dataStore.removeData(sessionId, id); } After removing the Entry from the entryMap, why is there an attempt to get the Entry? Is the "get" there for the case when the key is null? From the getKey code it does not look like the key will ever be null. This code is in apache-wicket-1.5-M2.1 Richard -- Quis custodiet ipsos custodes --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org