I think it is OK to make API breaks now - we are still in less-than-1.0.0 so according to SemVer it is allowed.
Martin Grigorov Wicket Training and Consulting On Thu, Mar 20, 2014 at 6:03 PM, Richter, Marvin < marvin.rich...@jestadigital.com> wrote: > Ok, I'll think about a better solution and will open a ticket. > > When will you expect your first final Major release? > So maybe we could implement a better Configuration but with API breaks? > > Marvin Richter > > > -----Original Message----- > From: Martin Grigorov [mailto:mgrigo...@apache.org] > Sent: Thursday, March 20, 2014 4:52 PM > To: users@wicket.apache.org > Subject: Re: custom bootstrap stylesheet > > I don't like it either but I see no other way at the moment. > Feel free to file a ticket for improvement. > > Martin Grigorov > Wicket Training and Consulting > > > On Thu, Mar 20, 2014 at 5:47 PM, Richter, Marvin < > marvin.rich...@jestadigital.com> wrote: > > > So I do have to override DefaultThemeProvider and return a > > BootstrapTheme(ISettings), where in Settings is my custom > > CssResourceReference? > > > > And then set this ThemeProvider as activeThemeProvider in the Settings? > > > > That sounds really strange to me. > > > > Marvin Richter > > > > > > -----Original Message----- > > From: Martin Grigorov [mailto:mgrigo...@apache.org] > > Sent: Thursday, March 20, 2014 3:35 PM > > To: users@wicket.apache.org > > Subject: Re: custom bootstrap stylesheet > > > > See https://github.com/l0rdn1kk0n/wicket-bootstrap/issues/339 for an > > example > > > > Martin Grigorov > > Wicket Training and Consulting > > > > > > On Thu, Mar 20, 2014 at 4:29 PM, Richter, Marvin < > > marvin.rich...@jestadigital.com> wrote: > > > > > Where should I set this? > > > The BootstrapSettings only provide the method : > > > setThemeProvider(ThemeProvider t); > > > > > > but not: > > > setTheme(Theme t); > > > > > > Marvin Richter > > > > > > -----Original Message----- > > > From: Martin Grigorov [mailto:mgrigo...@apache.org] > > > Sent: Thursday, March 20, 2014 3:23 PM > > > To: users@wicket.apache.org > > > Subject: Re: custom bootstrap stylesheet > > > > > > Hi, > > > > > > Set BootstrapTheme(IBootstrapSettings) as a default theme. > > > > > > Martin Grigorov > > > Wicket Training and Consulting > > > > > > > > > On Thu, Mar 20, 2014 at 4:11 PM, Richter, Marvin < > > > marvin.rich...@jestadigital.com> wrote: > > > > > > > Hi, > > > > > > > > How do I use a customized Bootstrap CCS file in wicket-bootstrap? > > > > > > > > I tried this: > > > > new BootstrapSettings().setCssResourceReference(new > > > > PackageResourceReference(CcaWebApplication.class, > > > > "customized-bootstrap.css")); > > > > > > > > Unfortunately getCssResourceReference will never be called, > > > > instead the reference from the DefaultThemeProvider will be used. > > > > > > > > But I don't really want to write my own ThemeProvider just to > > > > replace the CssResourceReference > > > > > > > > Best Regards, > > > > > > > > Marvin Richter > > > > > > > > > > > > > >
