Maxim, Feel free to fork it! I.e. move it to WicketStuff.
Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Thu, Oct 9, 2014 at 8:53 PM, Maxim Solodovnik <solomax...@gmail.com> wrote: > Additionally select2 seems to need to be forked to wicketstuff to be fixed, > should I do this? > > On 10 October 2014 00:49, Maxim Solodovnik <solomax...@gmail.com> wrote: > > > @Paul, @Martin > > > > Select2Choice sets back its value > > to getWebRequest().getRequestParameters().getParameterNames() > > in renderInitializationScript method [1] > > It seems like JS code like: $("#country1").select2("data", null); can be > > executed on clear input, but this seems to be workaround > > > > I'm not sure why [1] method is used to get value, maybe you can suggest > > correct way of fixing this? > > > > > > [1] > > > https://github.com/ivaynberg/wicket-select2/blob/master/wicket-select2/src/main/java/com/vaynberg/wicket/select2/Select2Choice.java#L62 > > > > On 9 October 2014 16:39, MadasamySankarapandian <madas...@mcruncher.com> > > wrote: > > > >> Thanks Maxim Solodovnik. > >> > >> On Thu, Oct 9, 2014 at 12:33 PM, Maxim Solodovnik <solomax...@gmail.com > > > >> wrote: > >> > >> > I also noticed this issue in our project, > >> > Will try to take a look at it > >> > > >> > On 9 October 2014 07:33, MadasamySankarapandian < > madas...@mcruncher.com > >> > > >> > wrote: > >> > > >> > > Thankyou very much for yours reply. > >> > > > >> > > I call formComponent.clearInput() in my ClearFormVisitor class. But > It > >> > does > >> > > not work. > >> > > I have created issue-96 > >> > > <https://github.com/ivaynberg/wicket-select2/issues/96> in > >> > wicket-select2 > >> > > project. > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > On Wed, Oct 8, 2014 at 12:13 AM, Maxim Solodovnik < > >> solomax...@gmail.com> > >> > > wrote: > >> > > > >> > > > Done, thanks for pointing this out > >> > > > > >> > > > On 7 October 2014 23:08, Paul Bors <p...@bors.ws> wrote: > >> > > > > >> > > > > Can you update this issue then? > >> > > > > > >> > > > > https://github.com/ivaynberg/wicket-select2/issues/93 > >> > > > > > >> > > > > On Tue, Oct 7, 2014 at 12:00 PM, Maxim Solodovnik < > >> > > solomax...@gmail.com> > >> > > > > wrote: > >> > > > > > >> > > > > > we recently moved this component to wicketstuff: > >> > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > https://github.com/wicketstuff/core/tree/master/jdk-1.7-parent/select2-parent > >> > > > > > > >> > > > > > to get Wicket7 compatible version > >> > > > > > > >> > > > > > > >> > > > > > On 7 October 2014 22:56, Paul Bors <p...@bors.ws> wrote: > >> > > > > > > >> > > > > > > You can also ask the developer via: > >> > > > > > > https://github.com/ivaynberg/wicket-select2/issues > >> > > > > > > > >> > > > > > > You should probably take a look over the open issues so that > >> you > >> > > are > >> > > > > > > familiar with that other developers faced. Maybe one of > those > >> > > issues > >> > > > > > might > >> > > > > > > be a road block for you? > >> > > > > > > > >> > > > > > > Although you will get a faster reply from Igor or another > >> Wicket > >> > > > > > developer > >> > > > > > > via this list :) > >> > > > > > > > >> > > > > > > On Tue, Oct 7, 2014 at 4:23 AM, Martin Grigorov < > >> > > > mgrigo...@apache.org> > >> > > > > > > wrote: > >> > > > > > > > >> > > > > > > > Hi, > >> > > > > > > > > >> > > > > > > > You should call formComponent.clearInput() too. > >> > > > > > > > > >> > > > > > > > Martin Grigorov > >> > > > > > > > Wicket Training and Consulting > >> > > > > > > > https://twitter.com/mtgrigorov > >> > > > > > > > > >> > > > > > > > On Tue, Oct 7, 2014 at 9:13 AM, MadasamySankarapandian < > >> > > > > > > > madas...@mcruncher.com> wrote: > >> > > > > > > > > >> > > > > > > > > > >> > > > > > > > > This is regarding wicket-select2 project. I could not > find > >> > any > >> > > > > > mailing > >> > > > > > > > > list for this project. That is why sending here. Please > >> some > >> > > one > >> > > > > help > >> > > > > > > me. > >> > > > > > > > > > >> > > > > > > > > I have created clear link to clear the form input > values. > >> > After > >> > > > > click > >> > > > > > > the > >> > > > > > > > > clear link, all components values are cleared except > >> > > > Select2Choice > >> > > > > > > > > component. > >> > > > > > > > > > >> > > > > > > > > Here with attached quickstart to recreate this problem. > >> > > > > > > > > > >> > > > > > > > > Follow below steps to recreate this problem > >> > > > > > > > > > >> > > > > > > > > * Download attachment and extract it. > >> > > > > > > > > * cd select2-quickstart. > >> > > > > > > > > * Then execute mvn clean package jetty:run > >> > > > > > > > > * Type localhost:8080 in browser > >> > > > > > > > > * Give the input to name and country field. > >> > > > > > > > > * Click clear link > >> > > > > > > > > > >> > > > > > > > > Now name(*TextField*) field value is cleared and > >> > > > > > > country(*Select2Choice*) > >> > > > > > > > > field value is not cleared. > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > -- > >> > > > > > > > > Thanks and regards > >> > > > > > > > > Madasamy > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > >> --------------------------------------------------------------------- > >> > > > > > > > > To unsubscribe, e-mail: > >> users-unsubscr...@wicket.apache.org > >> > > > > > > > > For additional commands, e-mail: > >> > users-h...@wicket.apache.org > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > -- > >> > > > > > WBR > >> > > > > > Maxim aka solomax > >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > > -- > >> > > > WBR > >> > > > Maxim aka solomax > >> > > > > >> > > > >> > > > >> > > > >> > > -- > >> > > Thanks and regards > >> > > Madasamy > >> > > > >> > > >> > > >> > > >> > -- > >> > WBR > >> > Maxim aka solomax > >> > > >> > >> > >> > >> -- > >> Thanks and regards > >> Madasamy > >> > > > > > > > > -- > > WBR > > Maxim aka solomax > > > > > > -- > WBR > Maxim aka solomax >
