Here's a solution to the clirr problem that should continue to work on
OSes with a different slant (/) on life ;) (BTW all of our servers are
Linux so we can slant both ways!)
It seems that clirr expects to see a forward slash regardless of whether
it's running on Linux or Windows so you can't use ${file.separator} on
Windows because that will give clirr a backslash.
Also... when clirr is running on windows it needs the precedeing **/ as
per the example on this page
http://mojo.codehaus.org/clirr-maven-plugin/examples/ignored-differences
.html otherwise it never matches the specified file.
So with both of these in mind the clirr className element should look
like:
<className>**/org/apache/wicket/feedback/FeedbackCollector</className>
to ensure it works on both Windows and *nix.
Regards,
Chris
> -----Original Message-----
> From: Martin Grigorov [mailto:mgrigo...@apache.org]
> Sent: Saturday, 14 February 2015 7:35 AM
> To: users@wicket.apache.org
> Subject: Re: Error building wicket-6.19.0 from src
>
> I use to say "because Windows users decided to suffer themselves (with
the
> decision to use Windows)" :-)
>
> If you find the reason and a solution then we would be happy to apply
it
> (unless it breaks the less-problematic OS-es)
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Fri, Feb 13, 2015 at 10:30 PM, Chris Colman
> <chr...@stepaheadsoftware.com
> > wrote:
>
> > There is a comment about this issue in the parent pom.xml.
> >
> > For anyone else who gest this issue you can find the
clirr-maven-plugin
> > in the parent pom.xml and change failOnError to false to allow the
build
> > to complete.
> >
> > <configuration>
> > <comparisonVersion>6.0.0</comparisonVersion>
> > <failOnError>false</failOnError>
> > <logResults>true</logResults>
> > <ignored>
> > <difference>
> > <!-- FeedbackCollector used to be final. Now
it
> > is non-final and so all existing methods were made final to keep
them
> > non-overridable. However, clirr does not take into account the class
> > going from final to non-final and thinks overridable methods were
made
> > final. We ignore this change to silence it. -->
> >
> >
<className>org${file.separator}apache${file.separator}wicket${file.separ
> > ator}feedback${file.separator}FeedbackCollector</className>
> > <method>*</method>
> > <differenceType>7014</differenceType>
> > </difference>
> > </ignored>
> > </configuration>
> >
> > I'm not sure why it's a Windows only problem when the plugin config
is
> > using file.separator and not explicitly '/'
> >
> > > -----Original Message-----
> > > From: Tobias Soloschenko [mailto:tobiassolosche...@googlemail.com]
> > > Sent: Saturday, 14 February 2015 5:06 AM
> > > To: users@wicket.apache.org
> > > Subject: Re: Error building wicket-6.19.0 from src
> > >
> > > Hi,
> > >
> > > which Java Version are you using currently? There is an issue of
the
> > > clirr plugin not to work with Java 8 at the moment. I filed in a
> > ticket:
> > >
> > > https://issues.apache.org/jira/browse/WICKET-5836
> > >
> > > kind regards
> > >
> > > Tobias
> > >
> > > Am 13.02.15 um 18:43 schrieb Chris Colman:
> > > > I'm compiling on Windows 8.1 64bit if that makes any difference.
> > > >
> > > > A few years ago there was an issue with clirr due to a forward
> > > > slash/backslash issue which caused it to compile ok on Linux/Mac
but
> > > > fail on Windows but I'm pretty sure that was resolved a long
time
> > ago.
> > > >
> > > > Regards,
> > > > Chris
> > > >
> > > >> -----Original Message-----
> > > >> From: Martin Grigorov [mailto:mgrigo...@apache.org]
> > > >> Sent: Thursday, 12 February 2015 11:22 PM
> > > >> To: users@wicket.apache.org
> > > >> Subject: Re: Error building wicket-6.19.0 from src
> > > >>
> > > >> Hi,
> > > >>
> > > >> According to the SCM history [1] this class hasn't been changed
> > since
> > > > Nov
> > > >> 26 2012.
> > > >>
> > > >>
> > > >> 1.
> > > >> https://github.com/apache/wicket/commits/wicket-6.x/wicket-
> > > >>
> > core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
> > > >>
> > > >> Martin Grigorov
> > > >> Wicket Training and Consulting
> > > >> https://twitter.com/mtgrigorov
> > > >>
> > > >> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman
> > > >> <chr...@stepaheadsoftware.com
> > > >>> wrote:
> > > >>> I get the following error when I try to compile the 6.19.0
source
> > > > code:
> > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
> > Method
> > > >>> 'public java.util.List collect()' is now final
> > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
Method
> > > >>> 'public java.util.List collect(org.apache.wicket.feed
> > > >>> back.IFeedbackMessageFilter)' is now final
> > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
Method
> > > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > > >>> setIncludeSession(boolean)' is now final
> > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector:
Method
> > > >>> 'public org.apache.wicket.feedback.FeedbackCollector
> > > >>> setRecursive(boolean)' is now final
> > > >>>
> > > >>> Any idea what could be causing this?
> > > >>>
> > > >>> Regards,
> > > >>> Chris
> > > >>>
> > > >
> >
---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> > > > For additional commands, e-mail: users-h...@wicket.apache.org
> > > >
> > >
> > >
> > >
---------------------------------------------------------------------
> > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> > > For additional commands, e-mail: users-h...@wicket.apache.org
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> > For additional commands, e-mail: users-h...@wicket.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
