Hi all,
Please consider the following simple implementation of AbstractRestResource
(6.22.0):
@ResourcePath("/rest/api")
public class MyRestResource extends
AbstractRestResource<JsonWebSerialDeserial>
{
public MyRestResource ()
{
super(new JsonWebSerialDeserial(new GsonObjectSerialDeserial()));
}
@MethodMapping(value = "/offices")
public List<Office> findOffices(
@RequestParam(value = "region", required = false) Integer regionId)
{
return findOfficesByRegion(regionId);
}
}
My question relates to the findOffices method and its filtering regionId
parameter when the value is not a valid integer. For example, consider the
request 'GET /rest/api/offices?region=AA'.
At the second step of AbstractRestResource.handleMethodExecution,
extractMethodParameters is invoked, which in turn triggers the conversion
of all parameters through the static method toObject.
When the conversion goes wrong and ConversionException is thrown, toObject
catches it, sets the response status to 400 and returns null!
Now, when my findOffices is finally executed, I get a null regionId but I
don't know whether it was not valid or the parameter was not present at
all. Checking the response status downstream is also particularly hard
because I have no getStatus (Tomcat 6 here, ouch!).
To my mind, findOffices should return null instead of the unfiltered list
of offices if the conversion went wrong, even because the response
status is 400 (as set by toObject). However, how can I know it?
Any suggestions?
Many thanks,
Fabio
