2017-09-19 9:35 GMT+03:00 Martin Grigorov <mgrigo...@apache.org>: > On Tue, Sep 19, 2017 at 8:12 AM, Martin Makundi < > martin.maku...@koodaripalvelut.com> wrote: > > > 2017-09-19 7:16 GMT+03:00 Martin Grigorov <martin.grigo...@gmail.com>: > > > > > On Sep 19, 2017 6:22 AM, "Martin Makundi" < > > > martin.maku...@koodaripalvelut.com> wrote: > > > > > > IMO it's better to big mang whole wicket to drop joda date. All wicket > 8 > > > without joda. > > > > > > > > > Said the person who still uses Wicket 1.4 for his apps... > > > > > > > Yes, incremental change is a pain so we big bang 1.4 ->8. > > > > > > > Everyone wants to see the Big Bang and this might be the reason to see > > > Wicket 8.0.0 in 2020. > > > > > > Dropping joda should not significantly slow down development. > > > > True, if your name is Stephen Colebourne and you know both APIs by heart! > I personally had to ask Google and StackOverflow.com several questions for > what I've done so far in the branch mentioned above. > > My vote on whether to merge this rafectoring to master branch will depend > on the diff in wicket-examples. >
Let's try it first. If it does not pass we can drop joda locally. So long as it is not a transient dependency it's doable. > > > > > > > > > > > > > > > ** > > > Martin > > > > > > 2017-09-18 22:43 GMT+03:00 Martin Grigorov <mgrigo...@apache.org>: > > > > > > > On Mon, Sep 18, 2017 at 6:50 AM, Martin Makundi < > > > > martin.maku...@koodaripalvelut.com> wrote: > > > > > > > > > Is it possible to also drop joda from wicketstuff for consistency? > > > > > > > > > > > > > IMO, the WicketStuff module must be exactly the same as the one in > > Wicket > > > > 7.x. > > > > Any changes in the API should be done in Wicket 8.x. > > > > This way when users migrate their apps to 8.x they can decide to take > > the > > > > short route and use the WicketStuff module. > > > > Later they can invest in reworking their code to the new API and use > > > again > > > > org.apache.wicket:wicket-datetime > > > > The WicketStuff module README should say that it will be available > only > > > for > > > > Wicket 8.x lifecycle, to prevent double maintenance. > > > > > > > > > > > > > 2017-09-17 22:09 GMT+03:00 Andrea Del Bene <an.delb...@gmail.com>: > > > > > > > > > > > +1 to move legacy code to WicketStuff. For 'legacy code' I mean > all > > > the > > > > > > code based on yui library and class StyleDateConverter which is > > > > tailored > > > > > on > > > > > > Joda time. > > > > > > > > > > > > > > > > > > > > > > > > On 16/09/2017 14:13, Martin Grigorov wrote: > > > > > > > > > > > >> Hi Maxim, > > > > > >> > > > > > >> Since I do not use wicket-datetime in my apps I also wanted to > > break > > > > it > > > > > >> hard by replacing Joda-Time with Java 8 classes. > > > > > >> But people who use it expressed concerns that it will be hard to > > > > migrate > > > > > >> this way. Everyone will have to do the same for his/her > > application. > > > > > >> I remember Igor even suggested to have univeral API that will > work > > > > with > > > > > >> java.util.Date, Joda-Time and Java 8! > > > > > >> > > > > > >> IMO the easiest thing that could be done is to copy the current > > code > > > > to > > > > > >> WicketStuff, as https://github.com/wicketstuff/wicket1.5-tree, > > and > > > > > rework > > > > > >> wicket-datetime to use Java 8 APIs. > > > > > >> > > > > > >> Martin Grigorov > > > > > >> Wicket Training and Consulting > > > > > >> https://twitter.com/mtgrigorov > > > > > >> > > > > > >> On Thu, Sep 14, 2017 at 7:11 AM, Maxim Solodovnik < > > > > solomax...@gmail.com > > > > > > > > > > > >> wrote: > > > > > >> > > > > > >> Hello Martin, > > > > > >>> > > > > > >>> I tried to continue this work, but it seems I need some > > information > > > > > >>> before I can proceed > > > > > >>> Could you please tell me What was the goal of these changes? > > > > > >>> > > > > > >>> I would remove joda-time, and use LocalDate, LocalTime instead > of > > > > Date > > > > > >>> As I can see you are using ZonedDateTime ... > > > > > >>> > > > > > >>> > > > > > >>> On Mon, Sep 11, 2017 at 9:01 PM, Martin Grigorov < > > > > mgrigo...@apache.org > > > > > > > > > > > >>> wrote: > > > > > >>> > > > > > >>>> Yes, if finished on time! > > > > > >>>> Wicket 7 requires Java 7 > > > > > >>>> > > > > > >>>> Martin Grigorov > > > > > >>>> Wicket Training and Consulting > > > > > >>>> https://twitter.com/mtgrigorov > > > > > >>>> > > > > > >>>> On Mon, Sep 11, 2017 at 3:34 PM, Rakesh A < > > > > iamrakes...@rediffmail.com > > > > > > > > > > > >>>> wrote: > > > > > >>>> > > > > > >>>> Hi, > > > > > >>>>> > > > > > >>>>> Is it going to be for Wicket 8 only ? > > > > > >>>>> > > > > > >>>>> Regards, > > > > > >>>>> Rakesh.A > > > > > >>>>> > > > > > >>>>> -- > > > > > >>>>> Sent from: http://apache-wicket.1842946.n > > > 4.nabble.com/Users-forum- > > > > > >>>>> f1842947.html > > > > > >>>>> > > > > > >>>>> ------------------------------------------------------------ > > > > > --------- > > > > > >>>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > > > > >>>>> For additional commands, e-mail: > users-h...@wicket.apache.org > > > > > >>>>> > > > > > >>>>> > > > > > >>>>> > > > > > >>> > > > > > >>> -- > > > > > >>> WBR > > > > > >>> Maxim aka solomax > > > > > >>> > > > > > >>> ------------------------------------------------------------ > > > > --------- > > > > > >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > > > > >>> For additional commands, e-mail: users-h...@wicket.apache.org > > > > > >>> > > > > > >>> > > > > > >>> > > > > > > > > > > > > ------------------------------------------------------------ > > > --------- > > > > > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > > > > > For additional commands, e-mail: users-h...@wicket.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > >
