No if you are a committer :-) On Fri, Feb 18, 2022 at 11:44 PM Maxim Solodovnik <solomax...@gmail.com> wrote:
> On Sat, 19 Feb 2022 at 03:04, Locke, Jonathan (Luo Shibo) < > jonath...@telenav.com> wrote: > > > Hi Martin, > > > > I was able to fix the problem as you suggested by adding: > > > > uses org.apache.wicket.IInitializer; > > > > to module-info.java in wicket-core. I created a pull request, but got an > > error trying to push it in IntelliJ: > > > > Can't create a new pull request: Push failed: remote: Permission to > > apache/wicket.git denied to jonathanlocke. unable to access ' > > https://github.com/apache/wicket.git/': The requested URL returned > error: > > 403 > > > > You need to fork the repo first :) > > > > > > Could we add this as a patch release to wicket 9.8.x? > > > > Thanks, > > > > Jon > > ________________________________ > > From: Martin Grigorov <mgrigo...@apache.org> > > Sent: Friday, February 18, 2022 2:55 AM > > To: users@wicket.apache.org <users@wicket.apache.org> > > Subject: Re: module error > > > > Hm. > > Looking at https://github.com/qos-ch/logback/commit/5186d2604b460f I > think > > we need the 'uses' only in the module where we call ServiceLoader.load(), > > i.e. in wicket-core. > > > > On Fri, Feb 18, 2022 at 11:53 AM Martin Grigorov <mgrigo...@apache.org> > > wrote: > > > > > Hi Jon, > > > > > > According to > > > > > > https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fwww.oracle.com%2fcorporate%2ffeatures%2funderstanding-java-9-modules.html&c=E,1,AlcuJddqQ1zhtdsihzDbje23huNpDs6zcgn19JZMXP_Y1UGGpZLts-DudDYPcu75JyHkjFHLNGJw3KmnkhBiyTndIjuRNCIVCuhKfLjxxCsCSVE,&typo=1 > > > > > > *provides…with.* A provides…with module directive specifies that a > module > > > provides a service implementation—making the module a *service > provider*. > > > The provides part of the directive specifies an interface or abstract > > > class listed in a module’s uses directive and the with part of the > > > directive specifies the name of the service provider class that > > implements > > > the interface or extends the abstract class. > > > > > > AFAIU it we need to add "uses org.apache.wicket.IInitializer" next to > all > > > "provides org.apache.wicket.IInitializer with > x.y.z.SomeImplementation;" > > > > > > Please try it and if it fixes the issue then send a PR! > > > > > > On Thu, Feb 17, 2022 at 8:16 PM Locke, Jonathan (Luo Shibo) < > > > jonath...@telenav.com> wrote: > > > > > >> > > >> Does anyone know what this is? Thanks -- Jon > > >> > > >> Exception in thread "main" java.util.ServiceConfigurationError: > > >> org.apache.wicket.IInitializer: module org.apache.wicket.core does not > > >> declare `uses` > > >> at java.base/ > > > https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fjava.util.ServiceLoader.fail&c=E,1,2x_TAvfY-cjOXXMq-PK1WQZp3HpRsfitQcisq2lSSdigHB1fuLg4Un_Ch3NVlsHPuGsx1r8PejxwY0JdlGRrY2C2drem7b8IxqPf8rSvijXa9Q,,&typo=1(https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fServiceLoader.java%3a589&c=E,1,cis_qtCg_hnDhiLzgOVbloD3TvvURxsW_mR8jY_GLJSaBpOtuXQJUWKaJ_JrPr61_00oAuYKmsG399grMpFwMKTC0mk8-ulQZF8Om98TsswwCgflaQ,,&typo=1) > > >> at java.base/java.util.ServiceLoader.checkCaller( > > > https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fServiceLoader.java%3a575&c=E,1,9qC3hJZa-Ru3NfQ0Cu_xyUf_1TZj3k6pzwnMObpxVdF9nmaNB2Rc-7lJtCoeo-It3FF8Ycad-exairuNw8NewoRyu6p0DmFxGH3lEQdd&typo=1 > > ) > > >> at java.base/java.util.ServiceLoader.<init>( > > > https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fServiceLoader.java%3a504&c=E,1,cG_JOkZF6cVpHdKnhFXnJdubZajDowT1aiqJ9nZMqXb8XP1HyPF8zffkOEW6pB1tIpgfKXetT1e_Av2K_LQiQ4IawQx7L_1ecDlhhxbW-A,,&typo=1 > > ) > > >> at java.base/java.util.ServiceLoader.load( > > > https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fServiceLoader.java%3a1687&c=E,1,ygqiqrdRgnPTbUdIwfyfaUU7NeLViUlaxe25c2cEr4ugbgFscntOvbGkTMrOa6kItGqMQ8hU1VDEzNaoKdV3-6CvBlcsrRFxlFuwjq6IqJK4Z_uzDIyI&typo=1 > > ) > > >> at org.apache.wicket.core@9.6.0 > > >> /org.apache.wicket.Application.initInitializers( > > > https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fApplication.java%3a556&c=E,1,xO9MV3KborBvFc4BL8FxC_4uuwfGaJqvrr-QVfntZI9iuOSmldotcVrEPvDYOTDHJI2hraMPQKQ5UOmqIxeJinkgxDyfchFVTm-AleqRwae6OLPTDfo,&typo=1 > > ) > > >> at org.apache.wicket.core@9.6.0 > > >> /org.apache.wicket.Application.initApplication( > > > https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fApplication.java%3a765&c=E,1,53VvaIOZTG7mETf35tkUcXDXfgaVHqiw29gxxq_4y_ZXHn8AGzbIbtFXR4tf6Oh_rbl7mOLXjgPBeEW3-pd7jBqEp-30i2WA26_CdN5uIVJtHsjBDJuep4DVDA,,&typo=1 > > ) > > >> at org.apache.wicket.core@9.6.0 > > >> /org.apache.wicket.protocol.http.WicketFilter.init( > > > https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fWicketFilter.java%3a441&c=E,1,He0Z2RxpNcC-ziRHqyjYFORYOn-LK_eNOZGT9zHWjBKPv3GAhtI8TUG2W-9YOiYdW6_ArVy_6GMjKIt_0nLh3u0FHuh0H-pscUXDZj11B8s,&typo=1 > > ) > > >> at org.apache.wicket.core@9.6.0 > > >> /org.apache.wicket.protocol.http.WicketFilter.init( > > > https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fWicketFilter.java%3a365&c=E,1,yo_2tJnAV4qbr-cq49OMx3sq4HWonvaqycQkJ_db-wYcUtt-8EyuDB-_tz0hjwH9lQgYN9mHJniiRilRX9pL2VXbKQEd6QnNcrLzbwVOzRzTSmM,&typo=1 > > ) > > >> > > >> > > [EXTERNAL EMAIL] CAUTION: This email originated from outside of Telenav. > > DO NOT CLICK links or attachments unless you recognize the sender and > know > > the content is safe. > > > > > -- > Best regards, > Maxim > -- Regards - Ernesto Reinaldo Barreiro
