The build should be fixed with https://github.com/apache/wicket/commit/8f8951b64db7006b131f7acfc8ad8f32bc6dca8a Please review it and let us know if you see a problem!
On Mon, Apr 3, 2023 at 11:01 AM Martin Grigorov <mgrigo...@apache.org> wrote: > Well, that's good news, I think! > The commons team is doing something ! > > Let's wait a bit and see whether we should depend on a stable release or > contibue with the PR that copies the classes. > > On Mon, Apr 3, 2023 at 10:59 AM Francesco Chicchiriccò < > ilgro...@apache.org> wrote: > >> As far as I can see the class >> >> org.apache.commons.fileupload2.pub.FileSizeLimitExceededException >> >> imported here: >> >> >> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java#L29 >> >> is not present anymore in >> >> https://github.com/apache/commons-fileupload >> >> hence the stacktrace reported below might deserve some trust after all. >> >> Regards. >> >> On 2023/04/03 07:49:32 Francesco Chicchiriccò wrote: >> > I see several recent commits on FileUpload, however: >> > >> > https://github.com/apache/commons-fileupload/commits/master >> > >> > and AFAICT Wicket 10.0.0-M1-SNAPSHOT depends on Commons FileUpload >> 2.0-SNAPSHOT no? >> > >> > Last Friday all was working on Syncope side as well: >> > >> > >> https://github.com/apache/syncope/commit/c65cbde960768ca370a6757d423ccb2c013b4704 >> > >> > Regards. >> > >> > On 2023/04/03 07:33:57 Martin Grigorov wrote: >> > > Hi Francesco, >> > > >> > > There are no new commits in master since Mar 24 - >> > > https://github.com/apache/wicket/commits/master. >> > > The PR about commons-fileupload2 is not yet merged to master - >> > > https://github.com/apache/wicket/pull/565. >> > > I see no reasons in Wicket for this exception ... >> > > >> > > One possible way to break the -SNAPSHOTs at Nexus is someone (Maxim >> ?!) to >> > > `mvn deploy`-ed PR 565 from his dev machine, but I doubt it. >> > > >> > > >> > > On Mon, Apr 3, 2023 at 10:04 AM Francesco Chicchiriccò < >> ilgro...@apache.org> >> > > wrote: >> > > >> > > > Hi there, >> > > > FTR this morning I've started receiving the following exception from >> > > > Syncope Console 4.0.0-SNAPSHOT, based on Wicket 10.0.0-M1-SNAPSHOT: >> > > > >> > > > java.lang.ClassNotFoundException: >> > > > org.apache.commons.fileupload2.pub.FileSizeLimitExceededException >> > > > at >> > > > >> org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1437) >> > > > at >> > > > >> org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1245) >> > > > at >> > > > >> org.apache.wicket.protocol.http.servlet.ServletWebRequest.newMultipartWebRequest(ServletWebRequest.java:431) >> > > > at >> > > > >> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1461) >> > > > at >> > > > >> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:793) >> > > > at >> > > > >> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:202) >> > > > at >> > > > >> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:139) >> > > > at >> > > > >> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:630) >> > > > at >> > > > >> org.apache.wicket.core.request.handler.ListenerRequestHandler.internalInvoke(ListenerRequestHandler.java:300) >> > > > at >> > > > >> org.apache.wicket.core.request.handler.ListenerRequestHandler.invoke(ListenerRequestHandler.java:274) >> > > > at >> > > > >> org.apache.wicket.core.request.handler.ListenerRequestHandler.invokeListener(ListenerRequestHandler.java:222) >> > > > at >> > > > >> org.apache.wicket.core.request.handler.ListenerRequestHandler.respond(ListenerRequestHandler.java:202) >> > > > at >> > > > >> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:910) >> > > > at >> > > > >> org.apache.wicket.request.RequestHandlerExecutor.execute(RequestHandlerExecutor.java:63) >> > > > at >> > > > >> org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:294) >> > > > at >> > > > >> org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:255) >> > > > at >> > > > >> org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:277) >> > > > at org.apache.wicket.protocol.ws >> > > > >> .AbstractUpgradeFilter.processRequestCycle(AbstractUpgradeFilter.java:67) >> > > > at >> > > > >> org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:208) >> > > > at >> > > > >> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:307) >> > > > >> > > > Regards. >> > > > >> > > > On 2023/03/31 07:55:27 Andrea Del Bene wrote: >> > > > > Habemus (almost...) FileUpload 2.0! >> > > > > https://lists.apache.org/thread/kknw9bn2t8dzpbwojpg2hcqbgqf1qyzc >> > > > > Thanks again to Maxim, although I'm sorry he had to spend time >> working to >> > > > > the PR 🙏 >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > On Sat, Mar 25, 2023 at 5:02 PM Greb Lindqvist < >> greb.lindqv...@gmail.com >> > > > > >> > > > > wrote: >> > > > > >> > > > > > Thank you! 🎉 >> > > > > > >> > > > > > On Sat, Mar 25, 2023 at 6:05 AM Maxim Solodovnik < >> solomax...@gmail.com >> > > > > >> > > > > > wrote: >> > > > > > >> > > > > > > https://github.com/apache/wicket/pull/565 :)) >> > > > > > > >> > > > > > > On Thu, 23 Mar 2023 at 19:49, Martin Grigorov < >> mgrigo...@apache.org> >> > > > > > > wrote: >> > > > > > > > >> > > > > > > > Hi, >> > > > > > > > >> > > > > > > > The plan is to copy the fileupload classes in Wicket. >> > > > > > > > Do you want to help with a PR ? >> > > > > > > > Just create a new Maven module, e.g. >> wicket-commons-fileupload, and >> > > > > > copy >> > > > > > > > the Jakarta related classes into >> > > > org/apache/wicket/commons/fileupload >> > > > > > > > package, i.e. to shade them. >> > > > > > > > Then update wicket-core to make use of the new module and >> classes. >> > > > > > > > >> > > > > > > > On Thu, Mar 23, 2023 at 1:46 PM Greb Lindqvist < >> > > > > > greb.lindqv...@gmail.com >> > > > > > > > >> > > > > > > > wrote: >> > > > > > > > >> > > > > > > > > Hello again, >> > > > > > > > > >> > > > > > > > > Like you, I've been watching >> > > > > > > > > >> > > > > > > >> > > > >> https://issues.apache.org/jira/projects/FILEUPLOAD/issues/FILEUPLOAD-309 >> > > > > > > > > >> > > > > > > > > If the FileUpload maintainers continue to be >> unresponsive, does >> > > > the >> > > > > > > Wicket >> > > > > > > > > team have a plan? >> > > > > > > > > Are you willing to wait indefinitely or might you commit >> to an >> > > > > > > alternative? >> > > > > > > > > If the latter, do you have a feel for when that might be? >> > > > > > > > > >> > > > > > > > > Thanks for any info. >> > > > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > -- >> > > > > > > Best regards, >> > > > > > > Maxim >> > > > > > > >> > > > > > > >> --------------------------------------------------------------------- >> > > > > > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> > > > > > > For additional commands, e-mail: users-h...@wicket.apache.org >> > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > -- >> > > > > Andrea Del Bene. >> > > > > Apache Wicket committer. >> > > > > >> > > > >> > > > >> --------------------------------------------------------------------- >> > > > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> > > > For additional commands, e-mail: users-h...@wicket.apache.org >> > > > >> > > > >> > > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> > For additional commands, e-mail: users-h...@wicket.apache.org >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> For additional commands, e-mail: users-h...@wicket.apache.org >> >>
