On Fri, 18 Apr 2008 08:48:45 +0200, Wenji Huang wrote:
...
> step-jump-cont-strict PASS on utrace patched 2.6.25 x86 kernel,

Isn't it SKIP (77)?  Please see below.


> fails on on utrace patched 2.6.25 x86_64 kernel. It says:
> ./step-jump-cont-strict: step-jump-cont-strict.c:501: test_singleblock (, 
> instruction -1): IP 0x400917 expected: found 0x400911

That should be correct as the Roland's fix for this case
  https://www.redhat.com/archives/utrace-devel/2008-April/msg00004.html
is still not present in either upstream 2.6.25 or Fedora 2.6.25-1.fc9.


> I found the definition of PTRACE_SINGLEBLOCK in test case affects the 
> result.
> If we remove the PTRACE_SINGLEBLOCK definition statements from __x86_64__ 
> branch, the test will PASS.

* Thanks for the bugreport, __i386__ was missing the defintion.
  It was provided only for __x86_64__ so far.

* I do not understand how it may make a difference on i386 / x86_64.
  Both the upstream and Fedora 2.6.25 kernels define it by:
  <linux/ptrace.h> -> <asm-x86/ptrace.h> -> <asm-x86/ptrace-abi.h>

  And it is always defined to the value 33 (decimal), isn't it?

* I guess it is a misunderstanding here, are you sure it is a PASS and not SKIP?
  Please check the return code $? if it is not 77 (SKIP).
  This is the style used by the automake testsuite framework in use.


Thanks for the report,
Jan

Reply via email to