Jim Keniston wrote: >> + /* >> + * -EINPROGRESS => we are on our way to quiesce. >> + * -EEXIST => we may be racing with core_clone and it has >> + * already attached an engine for us. >> + */ >> + if (ret && ((ret != EINPROGRESS) || (ret != -EALREADY))) > > s/||/&&/ -- as above.
This one's also missing a negation for EINPROGRESS, if the comments are correct.