On 08/01, Roland McGrath wrote: > > I've merged these (up to 5/6 so far). > > Now I'm looking at all the uses of ->stopped. > > * utrace_set_events > could test task_is_stopped_or_traced() || ->exit_state > > * utrace_control: > could test task_is_traced() || > ->exit_state && !(->utrace_flags & _UTRACE_DEATH_EVENTS) > (or let utrace_do_stop test the latter) > > * finish_utrace_stop > detects signal_wake_up(,1) (SIGKILL) > > (And the rest are just the bookkeeping to keep it set/cleared.) > > So I think it's now true that the only thing ->stopped is buying us is that > finish_utrace_stop test. Do you agree?
Yes, mostly, see my another reply. > Perhaps we can just replace that with __fatal_signal_pending Ah, I think in any case __fatal_signal_pending() is tidier for finish_utrace_stop(). Oleg.
