> > > I forgot that there is another issue (iirc a bit discussed too). > > > finish_callback_report() sets ->ops = utrace_detached_ops lockless! > > > > You'll have to remind me why this is a problem. > > Re: [PATCH 85] ptrace_attach_task: rely on utrace_barrier(), don't > check ->ops > https://www.redhat.com/archives/utrace-devel/2009-October/msg00180.html > > We already discussed this, but forgot to finish.
Ah, yes. I had that message still sitting in my folder to think about again and reply. > Do you agree with the patch? I think so, yes. It could use some more comments about the importance of the lock. I added a comment and merged it in. Thanks, Roland
