Hi Edgar, I must admit I have not had time to get into 3.10. I did nothing to prepare these for 3.10, they are just some fix ups that helped me get into 3.9.
3.10 has advanced beyond the code for these, that is good news. But I do hope not *everything* requires a test to get into 3.10. For example, Andreas Raab's fix for http://lists.squeakfoundation.org/pipermail/squeak-dev/2007-May/116585.html did not have a test but I hope the problem it addressed will not exist in 3.10. When I get to 3.10 I will reimplement my improvements, if necessary. - Chris On 5/25/07, Edgar J. De Cleene <[EMAIL PROTECTED]> wrote:
El 5/24/07 10:36 PM, "Chris Muller" <[EMAIL PROTECTED]> escribió: > I have just posted some of my own 3.9 fixes to Mantis that may be of interest: > > - fix for pageUp / pageDown keys in list morphs > > http://bugs.squeak.org/view.php?id=6506 Chris, thanks for working , but form recent 3.10 History morph you could read: 7091PluggableListMorphfix.cs Reporter: gilEgozi Summary: 0004719: [BUG][FIX] PageUp/PageDown works again in 3.9 Description: Another level of indirection was added to PluggableLisMorph, it's submorphs contain always only one submorph - a LazyListMorph which holds the actual list, this is 3.9 refactoring of PluggableListMorph which moved parts of the scrolling support into ScrollPane ScrollPane is not aware of the use of LazyListMorph and thus we always get a height of one morph.. ugly hack, due to code smell. Additional Information: see vUnadjustedScrollRange for same interface breach. CodeInCs: ReleaseBuilderFor3dot10 new updatePackages: ' Morphic-edc.120(119).mcd Have your 3.10 at 7112 ? Why not ? For the rest of your fixes, you do not have test for each. 3.10 have higher quality requirements. I know doing test is boring and uneasy in some cases, this time I take the risk of try and see (hope Ralph don't fire me) Edgar _______________________________________________ V3dot10 mailing list [email protected] http://lists.squeakfoundation.org/mailman/listinfo/v3dot10
_______________________________________________ V3dot10 mailing list [email protected] http://lists.squeakfoundation.org/mailman/listinfo/v3dot10
